Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Previous period visualization shows incorrect data #87969

Closed
rohit-gohri opened this issue Mar 26, 2025 · 2 comments · Fixed by #88058
Closed

Previous period visualization shows incorrect data #87969

rohit-gohri opened this issue Mar 26, 2025 · 2 comments · Fixed by #88058

Comments

@rohit-gohri
Copy link

rohit-gohri commented Mar 26, 2025

Environment

SaaS (https://sentry.io/)

Steps to Reproduce

  1. Go to Discover
  2. Add 2 measurements to plot
  3. Select previous period in Display options
  4. See that the 1 of the previous period is shown up as sum of the 2 metrics in graph but correctly when you hover to check the metric.

Expected Result

The graph should show the correct value same as what's show on hover.

Dotted Plot line should be around 9s

Actual Result

Dotted Plot line is around 15s

Image

Product Area

Discover

Link

No response

DSN

No response

Version

No response

@getsantry
Copy link
Contributor

getsantry bot commented Mar 26, 2025

Assigning to @getsentry/support for routing ⏲️

@getsantry
Copy link
Contributor

getsantry bot commented Mar 26, 2025

Routing to @getsentry/product-owners-discover for triage ⏲️

@getsantry getsantry bot moved this from Waiting for: Support to Waiting for: Product Owner in GitHub Issues with 👀 3 Mar 26, 2025
gggritso added a commit that referenced this issue Mar 31, 2025
Fixes a nasty bug with Discover. If someone chooses multiple Y axes and
sets the display to "Previous Period", they see something very weird:
the "previous period" series are _stacked_ so they have an incorrect
position on the chart. This happens because "previous period" values are
hard-coded _in multiple places_ to always stack. They really only work
when shown next to stacked area or bar charts!

This is very deep down, and hard to rip out. Instead, to fix the issue
for the user in question, I'm makes it so "Previous Period" always uses
stacked area charts. This has its own problems, but Discover isn't long
for this world. Newer UIs allow users to customize the visualization on
their own terms instead of using heuristics on the data.

Closes DAIN-122.
Closes #87969
andrewshie-sentry pushed a commit that referenced this issue Mar 31, 2025
Fixes a nasty bug with Discover. If someone chooses multiple Y axes and
sets the display to "Previous Period", they see something very weird:
the "previous period" series are _stacked_ so they have an incorrect
position on the chart. This happens because "previous period" values are
hard-coded _in multiple places_ to always stack. They really only work
when shown next to stacked area or bar charts!

This is very deep down, and hard to rip out. Instead, to fix the issue
for the user in question, I'm makes it so "Previous Period" always uses
stacked area charts. This has its own problems, but Discover isn't long
for this world. Newer UIs allow users to customize the visualization on
their own terms instead of using heuristics on the data.

Closes DAIN-122.
Closes #87969
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants