Skip to content

Commit 4d3116c

Browse files
author
keks
committed
fix http test
1 parent 5547dbf commit 4d3116c

File tree

1 file changed

+28
-24
lines changed

1 file changed

+28
-24
lines changed

http/http_test.go

+28-24
Original file line numberDiff line numberDiff line change
@@ -14,9 +14,10 @@ import (
1414

1515
func TestHTTP(t *testing.T) {
1616
type testcase struct {
17-
path []string
18-
v interface{}
19-
err error
17+
path []string
18+
v interface{}
19+
sendErr error
20+
nextErr error
2021
}
2122

2223
tcs := []testcase{
@@ -31,9 +32,8 @@ func TestHTTP(t *testing.T) {
3132
},
3233
},
3334
{
34-
path: []string{"error"},
35-
v: nil,
36-
err: errors.New("an error occurred"),
35+
path: []string{"error"},
36+
sendErr: errors.New("an error occurred"),
3737
},
3838
}
3939

@@ -47,38 +47,42 @@ func TestHTTP(t *testing.T) {
4747
}
4848

4949
res, err := c.Send(req)
50-
if err != nil {
51-
t.Fatal(err)
50+
if tc.sendErr != nil {
51+
if err == nil {
52+
t.Fatal("got nil error, expected:", tc.sendErr)
53+
} else if err.Error() != tc.sendErr.Error() {
54+
t.Fatalf("got error %q, expected %q", err, tc.sendErr)
55+
}
56+
57+
return
58+
} else if err != nil {
59+
t.Fatal("unexpected error:", err)
5260
}
5361

5462
v, err := res.Next()
55-
if tc.err == nil {
56-
if err != nil {
57-
t.Fatal(err)
58-
}
59-
} else {
63+
if tc.nextErr != nil {
6064
if err == nil {
61-
t.Fatal("got nil error, expected:", tc.err)
62-
} else if err.Error() != tc.err.Error() {
63-
t.Fatalf("got error %q, expected %q", err, tc.err)
65+
t.Fatal("got nil error, expected:", tc.nextErr)
66+
} else if err.Error() != tc.nextErr.Error() {
67+
t.Fatalf("got error %q, expected %q", err, tc.nextErr)
6468
}
69+
} else if err != nil {
70+
t.Fatal("unexpected error:", err)
6571
}
6672

6773
if !reflect.DeepEqual(v, tc.v) {
6874
t.Errorf("expected value to be %v but got %v", tc.v, v)
6975
}
7076

7177
_, err = res.Next()
72-
if tc.err == nil {
73-
if err != io.EOF {
74-
t.Fatal("expected io.EOF error, got:", err)
75-
}
76-
} else {
78+
if tc.nextErr != nil {
7779
if err == nil {
78-
t.Fatal("got nil error, expected:", tc.err)
79-
} else if err.Error() != tc.err.Error() {
80-
t.Fatalf("got error %q, expected %q", err, tc.err)
80+
t.Fatal("got nil error, expected:", tc.nextErr)
81+
} else if err.Error() != tc.nextErr.Error() {
82+
t.Fatalf("got error %q, expected %q", err, tc.nextErr)
8183
}
84+
} else if err != io.EOF {
85+
t.Fatal("expected io.EOF error, got:", err)
8286
}
8387
}
8488
}

0 commit comments

Comments
 (0)