create-react-class UMD module does not work in AMD environment

[jochenberger]

React is undefined in https://github.com/facebook/react/blob/15-stable/addons/create-react-class/create-react-class.js#L764

[gaearon]

What would be the right fix here? These modules were really meant as one-offs, and I’m not sure we plan to support AMD there unless there’s an easy fix.

[jochenberger]

How is the UMD module generated?

[syranide]

@gaearon I don't really understand where that code is coming from or how it's bundled, but it looks like it only works with React being globally defined, that must be a bug surely?

[gaearon]

Unfortunately it’s not really generated—we didn’t intend to post new versions, and there was some manual fiddling with Browserify-ed bundles to tack createClass onto the React global. Any fix would have to be manual.

it looks like it only works with React being globally defined, that must be a bug surely?

We are looking at the UMD bundle. Yes, this looks like a bug, I’m not disputing that, but it works in the browser (which was the main reason we made those bundles). So it’s not a high priority issue, but we’d love to see a fix there.

[jochenberger]

I'll see what I can do.

[syranide]

(function(f) {
  if (typeof exports === "object" && typeof module !== "undefined") {
    module.exports = f(require('react'));
  } else if (typeof define === "function" && define.amd) {
    define(['react'], f);
  } else {
    var g;
    if (typeof window !== "undefined") {
      g = window;
    } else if (typeof global !== "undefined") {
      g = global;
    } else if (typeof self !== "undefined") {
      g = self;
    } else {
      g = this;
    }
    if (typeof g.React === "undefined") {
      throw Error('React module should be required before createClass');
    }
    g.createReactClass = f(g.React);
  }
})(function(React)...

Should do it I think? Haven't tested. EDIT: Wups, changed React to react.

[jochenberger]

LGTM

[gaearon]

Can you try preparing .js and .min.js for this change, based on the versions checked into 15-stable? I know it doesn’t sound like much fun.

[syranide]

@gaearon Branch 15-stable?

[gaearon]

Yep.

[mondwan]

May I know how files in addon/create-react-class/ be generated?

Even I have edited addons/create-react-class/create-react-class.js, I cannot get the .min.js one by running npm run build etc.

So, how can I get such minified file? Or, which source file I should edited instead?

[gaearon]

It was generated by hand as a one-off because we didn’t think we’d make any changes to it. It’s silly but it is what it is. If you send a PR against non-minified version, I can minify it by hand again.