Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support tracing API in gethclient #28182

Open
s1na opened this issue Sep 23, 2023 · 4 comments · May be fixed by #31510
Open

Support tracing API in gethclient #28182

s1na opened this issue Sep 23, 2023 · 4 comments · May be fixed by #31510

Comments

@s1na
Copy link
Contributor

s1na commented Sep 23, 2023

Currently there is no built-in support for tracing in the ethclient/gethclient. This involves adding 4 new methods to gethclient:

  • TraceCall
  • TraceTransaction
  • TraceBlock
  • TraceChain
@bnovil
Copy link
Contributor

bnovil commented Sep 26, 2023

I'd like to do it. According to my understanding:

  1. adding 4 methods to gethclient.Client
  2. call methods in package tracers, for example ec.c.CallContext(ctx, &result, "debug_TraceTransaction")

Am I right?

@s1na
Copy link
Contributor Author

s1na commented Sep 26, 2023

@bnovil sounds great. You can also try using the types exposed in the eth/tracers package for the return values.

@krishpranav
Copy link

Hi, is this still open? can i work on this?

@s1na
Copy link
Contributor Author

s1na commented Jan 23, 2025

@krishpranav It is still open. We do need to pay some more attention to the API. I left a comment here: #28215 (comment).

I think we should also consider explicit API for pre-defined tracers, and I'm really thinking of the call tracer here. What I mean is additionally having the methods: TraceCallWithCallTracer and TraceTransactionWithCallTracer which will also return type-safe values.

@DeVikingMark DeVikingMark linked a pull request Mar 27, 2025 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
@s1na @bnovil @krishpranav and others