precompiles: Add SHA256 implementation #924
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
axic
previously approved these changes
Jun 8, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #924 +/- ##
==========================================
- Coverage 95.12% 94.29% -0.83%
==========================================
Files 140 142 +2
Lines 15892 16102 +210
==========================================
+ Hits 15117 15184 +67
- Misses 775 918 +143
Flags with carried forward coverage won't be shown. Click here to find out more.
|
985dbdb to
c102779
Compare
Member
Author
|
I tested this additionally on AMD Zen2 CPU with |
eadca78 to
23a3e62
Compare
rodiazet
approved these changes
Jun 11, 2024
Outdated, the code has changed a lot since.
5b6bf1b to
6042829
Compare
7867022 to
b697c4f
Compare
Copy the C implementation of SHA256 from Silkworm to evmone without any modifications. The original source file: https://github.com/erigontech/silkworm/blob/capi-0.19.0/silkworm/core/crypto/sha256.c
Convert C implementation of SHA256 to C++. evmone is declared as C++ only project. This also enabled previously missed coverage for the sha256.cpp file.
Improve SHA256 code quality by: - fixing/disabling some clang-tidy warnings, - adding `BufferState` constructor, - using `std::rotr()`, - using C++ attributes.
Use `std::byte` instead of `uint8_t` and drop the `use_cpu_extensions` parameter.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the SHA256 implementation from Silkworm and removes the precompile stub.