Skip to content

EOF validation test fixture #810

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
gumb0 merged 3 commits into from
Feb 12, 2024
Merged

EOF validation test fixture #810

gumb0 merged 3 commits into from
Feb 12, 2024

Conversation

@gumb0
Copy link
Member

@gumb0 gumb0 commented Feb 8, 2024

No description provided.

@gumb0 gumb0 added the EOF label Feb 8, 2024
@gumb0 gumb0 force-pushed the eof/validation-test-fixture branch from 20a341f to 6c4af90 Compare February 8, 2024 14:50
@codecov
Copy link

codecov bot commented Feb 8, 2024 •
edited
Loading

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (75eb1f2) 97.95% compared to head (e026e94) 97.88%.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master     #810      +/-   ##
==========================================
- Coverage   97.95%   97.88%   -0.08%     
==========================================
  Files         110      112       +2     
  Lines       10827    10630     -197     
==========================================
- Hits        10606    10405     -201     
- Misses        221      225       +4
Flag Coverage Δ
blockchaintests 59.88% <ø> (ø)
statetests 62.16% <ø> (ø)
statetests-silkpre 25.61% <0.00%> (+0.08%) ⬆️
unittests 95.87% <99.75%> (-0.10%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
test/unittests/eof_test.cpp 95.12% <100.00%> (+1.00%) ⬆️
test/unittests/eof_validation_test.cpp 100.00% <100.00%> (ø)
test/unittests/eof_validation.cpp 83.33% <83.33%> (ø)
test/unittests/eof_validation.hpp 60.00% <60.00%> (ø)

... and 1 file with indirect coverage changes

@gumb0 gumb0 force-pushed the eof/validation-test-fixture branch from 6c4af90 to 29dfc14 Compare February 8, 2024 15:27
@gumb0 gumb0 force-pushed the eof/validation-test-fixture branch 4 times, most recently from 0020286 to 9fa3350 Compare February 9, 2024 15:48
@gumb0 gumb0 marked this pull request as ready for review February 9, 2024 15:50
@gumb0 gumb0 force-pushed the eof/validation-test-fixture branch 3 times, most recently from 96a2920 to 7d18c1e Compare February 9, 2024 16:47
@gumb0 gumb0 requested review from chfast and pdobacz February 9, 2024 16:57
chfast
chfast approved these changes Feb 12, 2024
View reviewed changes
Copy link
Member

@chfast chfast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just wonder if add_test_case() is not too verbose.

@gumb0 gumb0 force-pushed the eof/validation-test-fixture branch from 358b5b8 to e026e94 Compare February 12, 2024 11:14
@gumb0 gumb0 merged commit 77cf1e9 into master Feb 12, 2024
@gumb0 gumb0 deleted the eof/validation-test-fixture branch February 12, 2024 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chfast chfast chfast approved these changes

@pdobacz pdobacz pdobacz approved these changes

Assignees

@gumb0 gumb0

Labels

EOF

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@gumb0 @chfast @pdobacz