Skip to content

Conversation

@pdobacz
Copy link
Member

@pdobacz pdobacz commented Jan 9, 2024

Closes #775

Inclusion is still somewhat pending, but this is likely to be included in the EOF instruction set to avoid code size regressions reported by compiler teams.

For this reason, I'm opening as draft, but this is reviewable. Does including a new opcode require any additional work?

@pdobacz pdobacz requested review from chfast and gumb0 January 9, 2024 08:24
@codecov
Copy link

codecov bot commented Jan 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (951b88d) 97.91% compared to head (5f61632) 97.94%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #786      +/-   ##
==========================================
+ Coverage   97.91%   97.94%   +0.02%     
==========================================
  Files         110      110              
  Lines       10670    10791     +121     
==========================================
+ Hits        10448    10569     +121     
  Misses        222      222              
Flag Coverage Δ
blockchaintests 59.88% <0.00%> (-0.49%) ⬇️
statetests 62.14% <0.00%> (-0.22%) ⬇️
statetests-silkpre 25.57% <5.98%> (-0.25%) ⬇️
unittests 95.94% <100.00%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
lib/evmone/advanced_instructions.cpp 100.00% <ø> (ø)
lib/evmone/baseline_instruction_table.cpp 100.00% <ø> (ø)
lib/evmone/instructions.hpp 100.00% <100.00%> (ø)
test/unittests/evm_calls_test.cpp 100.00% <100.00%> (ø)
test/unittests/instructions_test.cpp 89.58% <ø> (ø)
test/utils/bytecode.hpp 96.01% <100.00%> (+0.03%) ⬆️

@rodiazet rodiazet changed the title Implement RETURNDATALOAD (EOF) evmmax: Implement RETURNDATALOAD (EOF) Jan 9, 2024
@rodiazet rodiazet changed the title evmmax: Implement RETURNDATALOAD (EOF) Implement RETURNDATALOAD (EOF) Jan 9, 2024
@pdobacz pdobacz force-pushed the returndataload branch 2 times, most recently from b33d280 to c3bd0f8 Compare January 11, 2024 15:47
@pdobacz pdobacz marked this pull request as ready for review January 23, 2024 14:41
@pdobacz pdobacz requested a review from gumb0 January 24, 2024 16:57
@pdobacz pdobacz requested a review from gumb0 January 29, 2024 08:22
@pdobacz pdobacz merged commit 32b906a into master Jan 29, 2024
@pdobacz pdobacz deleted the returndataload branch January 29, 2024 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Implement RETURNDATALOAD (as part of EOF)

3 participants