-
Notifications
You must be signed in to change notification settings - Fork 331
Implement RETURNDATALOAD (EOF) #786
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #786 +/- ##
==========================================
+ Coverage 97.91% 97.94% +0.02%
==========================================
Files 110 110
Lines 10670 10791 +121
==========================================
+ Hits 10448 10569 +121
Misses 222 222
Flags with carried forward coverage won't be shown. Click here to find out more.
|
gumb0
reviewed
Jan 9, 2024
gumb0
reviewed
Jan 9, 2024
gumb0
reviewed
Jan 9, 2024
gumb0
reviewed
Jan 9, 2024
gumb0
reviewed
Jan 9, 2024
b33d280 to
c3bd0f8
Compare
c3bd0f8 to
8c560b0
Compare
8c560b0 to
fa48d7c
Compare
fa48d7c to
fd0dd47
Compare
gumb0
reviewed
Jan 25, 2024
gumb0
reviewed
Jan 25, 2024
fd0dd47 to
5f61632
Compare
gumb0
approved these changes
Jan 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #775
Inclusion is still somewhat pending, but this is likely to be included in the EOF instruction set to avoid code size regressions reported by compiler teams.
For this reason, I'm opening as draft, but this is reviewable. Does including a new opcode require any additional work?