Skip to content

Conversation

@chfast
Copy link
Member

@chfast chfast commented Nov 24, 2023

Implement the EIP-6780 "SELFDESTRUCT only in same transaction".
https://eips.ethereum.org/EIPS/eip-6780

This EIP changes the functionality of the SELFDESTRUCT instruction.
The new functionality will be only to send all Ether in the account
to the beneficiary, except that the current behavior is preserved when
SELFDESTRUCT is called in the same transaction a contract was created.

@chfast chfast requested review from gumb0, pdobacz and rodiazet November 24, 2023 15:20
@chfast chfast added the Cancun Changes for Cancun Ethereum spec revision label Nov 24, 2023
@codecov
Copy link

codecov bot commented Nov 24, 2023

Codecov Report

Merging #735 (90f4f80) into master (0174b53) will increase coverage by 0.00%.
Report is 3 commits behind head on master.
The diff coverage is 100.00%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #735   +/-   ##
=======================================
  Coverage   97.70%   97.71%           
=======================================
  Files         106      107    +1     
  Lines        9711     9746   +35     
=======================================
+ Hits         9488     9523   +35     
  Misses        223      223           
Flag Coverage Δ
blockchaintests 62.23% <ø> (ø)
statetests 60.69% <70.00%> (+<0.01%) ⬆️
statetests-silkpre 27.39% <20.58%> (-0.05%) ⬇️
unittests 95.67% <100.00%> (+0.12%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
test/state/account.hpp 100.00% <ø> (ø)
test/state/host.cpp 93.80% <100.00%> (+0.21%) ⬆️
test/state/state.cpp 100.00% <100.00%> (ø)
...t/unittests/state_transition_selfdestruct_test.cpp 100.00% <100.00%> (ø)

Implement the EIP-6780 "SELFDESTRUCT only in same transaction".
https://eips.ethereum.org/EIPS/eip-6780

This EIP changes the functionality of the SELFDESTRUCT instruction.
The new functionality will be only to send all Ether in the account
to the beneficiary, except that the current behavior is preserved when
SELFDESTRUCT is called in the same transaction a contract was created.
@chfast chfast force-pushed the eip6780_selfdestruct branch from 2d31f5b to 90f4f80 Compare November 27, 2023 10:08
@chfast chfast merged commit 2fb7cc1 into master Nov 27, 2023
@chfast chfast deleted the eip6780_selfdestruct branch November 27, 2023 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Cancun Changes for Cancun Ethereum spec revision

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants