Skip to content

statetest: Validate EOF containers in test state #593

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
chfast merged 1 commit into from
Mar 26, 2023
Merged

statetest: Validate EOF containers in test state #593

chfast merged 1 commit into from
Mar 26, 2023

Conversation

@rodiazet
Copy link
Member

@rodiazet rodiazet commented Mar 23, 2023 •
edited by axic
Loading

Part of #585.

@rodiazet rodiazet force-pushed the verify-statetest branch 4 times, most recently from 454b866 to 2f5f38a Compare March 23, 2023 15:25
@rodiazet rodiazet marked this pull request as ready for review March 23, 2023 15:25
@rodiazet rodiazet changed the title Verify statetest Verify deployed contact before running statetest Mar 23, 2023
@rodiazet rodiazet requested a review from chfast March 23, 2023 15:26
chfast
chfast requested changes Mar 23, 2023
View reviewed changes
@rodiazet rodiazet requested a review from chfast March 24, 2023 09:59
chfast
chfast requested changes Mar 24, 2023
View reviewed changes
@chfast chfast changed the title Verify deployed contact before running statetest statetest: Validate EOF containers in test state Mar 24, 2023
chfast
chfast requested changes Mar 24, 2023
View reviewed changes
Copy link
Member

@chfast chfast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should also add one test to https://github.com/ethereum/evmone/blob/master/test/integration/statetest/CMakeLists.txt.

@chfast chfast added the EOF label Mar 24, 2023
@chfast chfast force-pushed the verify-statetest branch from 6391740 to 08f36f9 Compare March 26, 2023 09:38
@codecov
Copy link

codecov bot commented Mar 26, 2023 •
edited
Loading

Codecov Report

Merging #593 (08f36f9) into master (6aaf6b1) will increase coverage by 0.05%.
The diff coverage is 100.00%.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master     #593      +/-   ##
==========================================
+ Coverage   96.79%   96.85%   +0.05%     
==========================================
  Files          73       73              
  Lines        7268     7276       +8     
==========================================
+ Hits         7035     7047      +12     
+ Misses        233      229       -4
Flag Coverage Δ
blockchaintests 63.71% <ø> (ø)
statetests 63.10% <33.33%> (-0.06%) ⬇️
unittests 93.62% <100.00%> (+0.10%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
test/statetest/statetest_runner.cpp 100.00% <100.00%> (ø)

... and 3 files with indirect coverage changes

@chfast chfast merged commit 0cfd850 into master Mar 26, 2023
@chfast chfast deleted the verify-statetest branch March 26, 2023 10:06
@pdobacz pdobacz mentioned this pull request Jan 2, 2024
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chfast chfast chfast approved these changes

Assignees

No one assigned

Labels

EOF

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@rodiazet @chfast