From 91e492bd2eccca9440597a005717db3413a70d00 Mon Sep 17 00:00:00 2001 From: Ryan P Kilby Date: Fri, 10 May 2019 10:43:07 -0700 Subject: [PATCH 1/2] Rollback #6435 Python 2 loses the exception context with an explicit `raise exc`, making debugging significantly more difficult. --- rest_framework/views.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/rest_framework/views.py b/rest_framework/views.py index 9d5d959e9d..04951ed93d 100644 --- a/rest_framework/views.py +++ b/rest_framework/views.py @@ -463,7 +463,7 @@ def raise_uncaught_exception(self, exc): renderer_format = getattr(request.accepted_renderer, 'format') use_plaintext_traceback = renderer_format not in ('html', 'api', 'admin') request.force_plaintext_errors(use_plaintext_traceback) - raise exc + raise # Note: Views are made CSRF exempt from within `as_view` as to prevent # accidental removal of this exemption in cases where `dispatch` needs to From b1c4d8b59b67084ed07a35ea9a35629805039aaa Mon Sep 17 00:00:00 2001 From: Ryan P Kilby Date: Fri, 10 May 2019 10:52:20 -0700 Subject: [PATCH 2/2] Update version and release notes for v3.9.4. --- docs/community/release-notes.md | 6 ++++++ rest_framework/__init__.py | 2 +- 2 files changed, 7 insertions(+), 1 deletion(-) diff --git a/docs/community/release-notes.md b/docs/community/release-notes.md index 6fcb5bb6b3..cda24809fb 100644 --- a/docs/community/release-notes.md +++ b/docs/community/release-notes.md @@ -40,6 +40,12 @@ You can determine your currently installed version using `pip show`: ## 3.9.x series +### 3.9.4 + +**Date**: [10th May 2019] + +This is a maintenance release that fixes an error handling bug under Python 2. + ### 3.9.3 **Date**: [29th April 2019] diff --git a/rest_framework/__init__.py b/rest_framework/__init__.py index 53dc7bd47f..45f3213ee8 100644 --- a/rest_framework/__init__.py +++ b/rest_framework/__init__.py @@ -8,7 +8,7 @@ """ __title__ = 'Django REST framework' -__version__ = '3.9.3' +__version__ = '3.9.4' __author__ = 'Tom Christie' __license__ = 'BSD 2-Clause' __copyright__ = 'Copyright 2011-2019 Encode OSS Ltd'