Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: elastic/elasticsearch-rails
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: main
Choose a base ref
...
head repository: elastic/elasticsearch-rails
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 5.x
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 20 commits
  • 29 files changed
  • 5 contributors

Commits on Apr 7, 2017

  1. Added the "Compatibility" chapter to the READMEs

    In order to make the support for different Elasticsearch versions more clear,
    a special "Compatibility" chapter has been added to the main README and
    individual gem READMEs.
    
    The versioning scheme follows the scheme for the Elasticsearch Ruby client,
    ie. the version number matches the supported major version of Elasticsearch.
    
    See:
    
    * elastic/elasticsearch-ruby@3bdb385
    karmi committed Apr 7, 2017
    Configuration menu
    Copy the full SHA
    620dcca View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    05dd0e1 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    839da59 View commit details
    Browse the repository at this point in the history
  4. Release 5.0.0

    karmi committed Apr 7, 2017
    Configuration menu
    Copy the full SHA
    83107f2 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    c243026 View commit details
    Browse the repository at this point in the history

Commits on Apr 10, 2017

  1. Configuration menu
    Copy the full SHA
    d1d4dd9 View commit details
    Browse the repository at this point in the history
  2. [STORE] Updated the dependency for "elasticsearch" and "elasticsearch…

    …-model" to `5.x`
    
    Related: #693
    karmi committed Apr 10, 2017
    Configuration menu
    Copy the full SHA
    2010cf2 View commit details
    Browse the repository at this point in the history

Commits on May 4, 2017

  1. [MODEL] Updated the dependency on "elasticsearch" to 5.x

    The 5.x versions should depend on the corresponding version of the Ruby client.
    
    Related: #702
    karmi committed May 4, 2017
    Configuration menu
    Copy the full SHA
    bce6c42 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    ccf2e8e View commit details
    Browse the repository at this point in the history
  3. Release 5.0.1

    karmi committed May 4, 2017
    Configuration menu
    Copy the full SHA
    22b698a View commit details
    Browse the repository at this point in the history

Commits on Dec 4, 2017

  1. [MODEL] Updated the changes method name in Indexing to `changes_t…

    …o_save` for compatibility with Rails 5.1
    
    Without this patch, the log on Rails 5.1 is full of deprecation warnings like:
    
        DEPRECATION WARNING: The behavior of `changed_attributes` inside of after callbacks will be changing in the next version of Rails. The new return value will reflect the behavior of calling the method after `save` returned (e.g. the opposite of what it returns now). To maintain the current behavior, use `saved_changes.transform_values(&:first)` instead. (called from update_funding_caches at...
    
    It was first reported in #714.
    
    This patch fixes #758.
    Geesu authored and karmi committed Dec 4, 2017
    Configuration menu
    Copy the full SHA
    900899c View commit details
    Browse the repository at this point in the history
  2. [MODEL] Fixed the handling of changed attributes in Indexing to wor…

    …k with older Rails versions
    
    This patch builds on work in #738 by @jkeam and #758 by @Geesu to prevent deprecation warnings on Rails 5.1
    due to changes in the handling of "changed attributes", originally reported by @davedash in #714.
    
    It's primary focus is to restore the compatibility with older Rails versions (so we don't break compatibility
    without proper version bump and in a single isolated commit), and to make the naming a bit more descriptive.
    
    First, the condition has been changed to work with the `changes_to_save` and `changes` methods, as opposed
    to the original `changed_attributes` / `attributes_in_database` naming. This communicates much more clearly
    the intent, and the original usage of `changed_attributes` has been misleading.
    
    Also, the "internal instance variable" which keeps track of the changes has been renamed to `@__changed_model_attributes`,
    in order to cleary differentiate it from the `changed_attributes` method name in older ActiveRecord versions.
    
    Closes #758
    karmi committed Dec 4, 2017
    Configuration menu
    Copy the full SHA
    a41d9a2 View commit details
    Browse the repository at this point in the history
  3. Release 5.0.2

    karmi committed Dec 4, 2017
    Configuration menu
    Copy the full SHA
    3b6f27d View commit details
    Browse the repository at this point in the history

Commits on Jun 28, 2018

  1. Update gitignore

    estolfo committed Jun 28, 2018
    Configuration menu
    Copy the full SHA
    0239bd1 View commit details
    Browse the repository at this point in the history
  2. [CI] Update Travis matrix for 5.x branch (#806)

    * [CI] Update Travis matrix
    
    * [MODEL] Mock the #to_ary method in multimodel test for Ruby 2.2
    estolfo authored Jun 28, 2018
    Configuration menu
    Copy the full SHA
    8d79b98 View commit details
    Browse the repository at this point in the history

Commits on Jun 29, 2018

  1. Configuration menu
    Copy the full SHA
    931830c View commit details
    Browse the repository at this point in the history

Commits on Jul 4, 2018

  1. Configuration menu
    Copy the full SHA
    10028bb View commit details
    Browse the repository at this point in the history
  2. Release 5.1.0

    estolfo committed Jul 4, 2018
    Configuration menu
    Copy the full SHA
    0b000bd View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    212b37a View commit details
    Browse the repository at this point in the history

Commits on Aug 17, 2018

  1. [MODEL] Support :scope, :query and :preprocess importing options for …

    …Mongoid (#786)
    
    * [MODEL] Support scope, query and preprocess importing options in Mongoid Adapter
    
    * test(mongoid-adapter): add testing for importing mongoid model with default scope
    Seitk authored and estolfo committed Aug 17, 2018
    Configuration menu
    Copy the full SHA
    bfdd224 View commit details
    Browse the repository at this point in the history
Loading