Conversation
Contributor
paulmedynski
commented
Mar 19, 2025
- Tidied up the existing Performance benchmarks.
- Added environment variables to specify config files.
- Removed Newtonsoft.Json as a dependency.
- Simplified csproj a bit.
- Tidied up the existing Performance benchmarks. - Added environment variables to specify config files. - Removed Newtonsoft.Json as a dependency. - Simplified csproj a bit.
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR tidies up the performance tests by refactoring configuration loading, removing the Newtonsoft.Json dependency, and simplifying project files.
- Introduces a new JSON configuration loader using System.Text.Json.
- Updates performance test configuration for benchmarks and data types across several files.
- Revises the BUILDGUIDE to include instructions for setting up the runner configuration and an empty database.
Reviewed Changes
Copilot reviewed 6 out of 8 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/Microsoft.Data.SqlClient/tests/PerformanceTests/Config/Loader.cs | Adds a utility to load JSON configs with environment variable overrides. |
| BUILDGUIDE.md | Updates usage instructions for benchmarks and configuration management. |
| src/Microsoft.Data.SqlClient/tests/PerformanceTests/Config/DataTypes.cs | Introduces a Load() method to load data types configuration. |
| src/Microsoft.Data.SqlClient/tests/PerformanceTests/Config/Config.cs | Adds a Load() method for benchmark configuration. |
| src/Microsoft.Data.SqlClient/tests/PerformanceTests/Program.cs | Refactors config loading and benchmark execution from a static context to an instance context. |
| src/Microsoft.Data.SqlClient/tests/PerformanceTests/BenchmarkRunners/BaseRunner.cs | Replaces Newtonsoft.Json deserialization with the new Loader API. |
Files not reviewed (2)
- src/Microsoft.Data.SqlClient/tests/PerformanceTests/Microsoft.Data.SqlClient.PerformanceTests.csproj: Language not supported
- tools/props/Versions.props: Language not supported
paulmedynski
commented
Mar 19, 2025
paulmedynski
commented
Mar 19, 2025
paulmedynski
commented
Mar 19, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3230 +/- ##
==========================================
+ Coverage 72.73% 72.92% +0.18%
==========================================
Files 288 303 +15
Lines 59527 59527
==========================================
+ Hits 43298 43409 +111
+ Misses 16229 16118 -111
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
mdaigle
approved these changes
Mar 19, 2025
ErikEJ
reviewed
Mar 20, 2025
- Improved benchmark running instructions.
samsharma2700
approved these changes
Mar 22, 2025
This was referenced Jul 25, 2025
Open
This was referenced Dec 22, 2025
This was referenced Dec 29, 2025
This was referenced Jan 12, 2026
This was referenced Jan 19, 2026
This was referenced Jan 26, 2026
This was referenced Feb 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.