-
Notifications
You must be signed in to change notification settings - Fork 5.3k
Closed
Labels
area-System.Text.Jsontenet-performancePerformance related issuePerformance related issuetenet-performance-benchmarksIssue from performance benchmarkIssue from performance benchmark
Milestone
Description
Run Information
| Architecture | x64 |
|---|---|
| OS | Windows 10.0.18362 |
| Baseline | 20b42d582956965a97376da96e709d1074d51f36 |
| Compare | 1dc6524d3d4dc9ba2b661ffd9689dcca6bcebf55 |
| Diff | Diff |
Regressions in System.Text.Json.Serialization.Tests.ReadJson<Int32>
| Benchmark | Baseline | Test | Test/Base | Test Quality | Edge Detector | Baseline IR | Compare IR | IR Ratio | Baseline ETL | Compare ETL |
|---|---|---|---|---|---|---|---|---|---|---|
| DeserializeFromStream - Duration of single invocation | 348.50 ns | 407.01 ns | 1.17 | 0.10 | False |
Repro
git clone https://github.com/dotnet/performance.git
py .\performance\scripts\benchmarks_ci.py -f net6.0 --filter 'System.Text.Json.Serialization.Tests.ReadJson<Int32>*'Details
Payloads
Histogram
System.Text.Json.Serialization.Tests.ReadJson<Int32>.DeserializeFromStream
Description of detection logic
IsRegressionChecked: Marked as regression because the three check build points were 0.05 greater than the baseline.
IsImprovementBase: Marked as not an improvement because the compare was not 5% less than the baseline, or the value was too small.
IsRegressionBase: Marked as regression because the compare was 5% greater than the baseline, and the value was not too small.
IsRegressionChecked: Marked as regression because the three check build points were 0.05 greater than the baseline.
IsRegressionWindowed: Marked as regression because 407.00701308204737 > 375.81321161574164.
IsChangePoint: Marked as a change because one of 7/2/2022 7:35:06 PM, 7/6/2022 3:55:24 AM, 7/29/2022 4:34:00 PM, 8/2/2022 8:20:46 AM falls between 7/24/2022 6:07:37 PM and 8/2/2022 8:20:46 AM.
IsRegressionStdDev: Marked as regression because -17.75849101443771 (T) = (0 -400.84109282815365) / Math.Sqrt((77.0010330960521 / (55)) + (67.75365560726331 / (18))) is less than -1.993943367845047 = MathNet.Numerics.Distributions.StudentT.InvCDF(0, 1, (55) + (18) - 2, .025) and -0.11194792421276333 = (360.4854904621015 - 400.84109282815365) / 360.4854904621015 is less than -0.05.
IsImprovementBase: Marked as not an improvement because the compare was not 5% less than the baseline, or the value was too small.
IsChangeEdgeDetector: Marked not as a regression because Edge Detector said so.
Docs
Profiling workflow for dotnet/runtime repository
Benchmarking workflow for dotnet/runtime repository
| Architecture | x64 |
|---|---|
| OS | Windows 10.0.18362 |
| Baseline | 20b42d582956965a97376da96e709d1074d51f36 |
| Compare | 1dc6524d3d4dc9ba2b661ffd9689dcca6bcebf55 |
| Diff | Diff |
Regressions in System.Text.Json.Serialization.Tests.ReadJson<Nullable<DateTimeOffset>>
| Benchmark | Baseline | Test | Test/Base | Test Quality | Edge Detector | Baseline IR | Compare IR | IR Ratio | Baseline ETL | Compare ETL |
|---|---|---|---|---|---|---|---|---|---|---|
| DeserializeFromStream - Duration of single invocation | 461.46 ns | 502.18 ns | 1.09 | 0.08 | False |
Repro
git clone https://github.com/dotnet/performance.git
py .\performance\scripts\benchmarks_ci.py -f net6.0 --filter 'System.Text.Json.Serialization.Tests.ReadJson<Nullable<DateTimeOffset>>*'Details
Payloads
Histogram
System.Text.Json.Serialization.Tests.ReadJson<Nullable<DateTimeOffset>>.DeserializeFromStream
Description of detection logic
IsRegressionChecked: Marked as regression because the three check build points were 0.05 greater than the baseline.
IsImprovementBase: Marked as not an improvement because the compare was not 5% less than the baseline, or the value was too small.
IsRegressionBase: Marked as regression because the compare was 5% greater than the baseline, and the value was not too small.
IsRegressionChecked: Marked as regression because the three check build points were 0.05 greater than the baseline.
IsRegressionWindowed: Marked as regression because 502.1774025240621 > 485.5953891299132.
IsChangePoint: Marked as a change because one of 7/2/2022 7:35:06 PM, 7/6/2022 3:55:24 AM, 7/29/2022 4:34:00 PM, 8/2/2022 8:20:46 AM falls between 7/24/2022 6:07:37 PM and 8/2/2022 8:20:46 AM.
IsRegressionStdDev: Marked as regression because -16.917063821627785 (T) = (0 -516.4716608319743) / Math.Sqrt((57.56346344931666 / (55)) + (144.52620479952807 / (18))) is less than -1.993943367845047 = MathNet.Numerics.Distributions.StudentT.InvCDF(0, 1, (55) + (18) - 2, .025) and -0.10948185835092948 = (465.50708057509684 - 516.4716608319743) / 465.50708057509684 is less than -0.05.
IsImprovementBase: Marked as not an improvement because the compare was not 5% less than the baseline, or the value was too small.
IsChangeEdgeDetector: Marked not as a regression because Edge Detector said so.
Docs
Profiling workflow for dotnet/runtime repository
Benchmarking workflow for dotnet/runtime repository
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
area-System.Text.Jsontenet-performancePerformance related issuePerformance related issuetenet-performance-benchmarksIssue from performance benchmarkIssue from performance benchmark
_1.png)
)_1.png)