Accessibility: Items not read aloud

[UltimateGG]

At least with ChromeVox:
Using arrow keys does not announce the highlighted value.
https://www.w3.org/WAI/ARIA/apg/patterns/combobox/examples/combobox-select-only/

I cannot figure out why, compared html to the WAI page's combobox, they look the same.

[UltimateGG]

The issue is value not being in the dependency array for the useMemo of selectedItemId:
https://github.com/pacocoursey/cmdk/blob/13f11c4f918cb4f7eb6254b4087a9cc83928b503/cmdk/src/index.tsx#L790C1-L790C9

I'd make a pull request but there is still some problems:

• To read it must have the element focused with the aria-activedescendant attribute
• If there is no Command.Input there is no focused element with activedescendant
• If an item is clicked the input is no longer focused
• The query for a selected item uses encodeURIComponent - Even on the demo website this breaks as spaces get "%20"'d and it thinks nothing is selected

[jacobsickels]

Please merge this change!

[Alechuu]

Bumping this up, just encountered this issue as well and thought we had implemented it in a wrong way.

[SaveliiLukash]

We just came across this, too, when migrating from react-select, which is not actively maintained, to shadcn/ui's implementation of Combobox that uses cmdk. It appears that the last release of cmdk was over half a year ago, with many active PRs waiting to be merged.

@pacocoursey The component is great, we are grateful for your work and would like to use it in our projects. Are there any plans for this module to continue to be maintained?

[julian-bennecker-syzygy]

We are also interested in using this component and need it to meet WCAG compliance requirements. Accessibility is crucial for our projects, and this issue is a blocker for us.

@pacocoursey Are there any plans to address this or ways we could contribute to help resolve it? We’d be happy to assist in any way we can to move this forward. Thank you for the great work on cmdk!

[bkoca]

We too are leveraging this alongside shadcn/ui and are running into the same issues with meeting accessibility guidelines. @pacocoursey is this still being maintained or are there ways we can help? It's a very useful component for us!

[t-hamano]

I have found that in some scenarios, the aria-activedescendant attribute still does not get applied correctly. See #373 for more details.