Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] TikTok links still opening in web browser #543

Closed
MulverineX opened this issue Aug 5, 2024 · 12 comments
Closed

[BUG] TikTok links still opening in web browser #543

MulverineX opened this issue Aug 5, 2024 · 12 comments
Labels
bug Something isn't working Waiting For Release Implemented but not released yet

Comments

@MulverineX
Copy link

Describe the bug
TikTok links opened from chat apps like Beeper & Discord open in Firefox.

To Reproduce
Steps to reproduce the behavior:

  • Ensure TikTok is not installed
  • Add TikTok to supported links in YTDLnis App Info
  • Force stop chat apps
  • Open up a chat app and attempt to open the TikTok link in YTDLnis

Expected behavior
The link should open the popup downloader dialogue when pressed.

(please complete the following information):

  • Android Version: 14
  • App Version: 1.7.9
@MulverineX MulverineX added the bug Something isn't working label Aug 5, 2024
@zaednasr
Copy link
Collaborator

zaednasr commented Aug 7, 2024

This is a Google issue. Since android 12 and above, Google wants the app to undergo verification to allow links to open by default to it. But since that can't happen because this app is also a youtube downloader, it is what it is.

@zaednasr zaednasr closed this as completed Aug 7, 2024
@MulverineX
Copy link
Author

@zaednasr I don't think I phrased the report very well, I'm not talking about automatic/default behavior. Manually setting the link association isn't working.

https://youtu.be/UvVk_HdqzdQ

@zaednasr zaednasr reopened this Aug 7, 2024
@7Grn
Copy link

7Grn commented Aug 7, 2024

YTDLnis is only 'tiktok.com' appears to be on the list
Screenshot
@zaednasr can you add "www.tiktok.com" link

@MulverineX
Copy link
Author

Oh yeah true that might be the issue here

@7Grn
Copy link

7Grn commented Aug 7, 2024

Oh yeah true that might be the issue here

@MulverineX currently it works fine if you use the "tiktok.com" link

@zaednasr
Copy link
Collaborator

zaednasr commented Aug 7, 2024

Alright, i added the www.titktok but i cant seem to make the app show up lol.

@7Grn
Copy link

7Grn commented Aug 7, 2024

ahh sorry if i misunderstood you as a YTDLnis dev

@zaednasr
Copy link
Collaborator

zaednasr commented Aug 7, 2024

im the dev

@zaednasr
Copy link
Collaborator

zaednasr commented Aug 7, 2024

#447 (comment)

Check this out. I installed this app and it works if i long press and tap open. Its meant to bypass the android 12+ limitations

@zaednasr
Copy link
Collaborator

zaednasr commented Aug 7, 2024

Meanwhile ill add the other variants for each supported url in the app to be safe

@MulverineX
Copy link
Author

I'm just trying to figure out why YouTube Revanced works and this doesn't

@zaednasr
Copy link
Collaborator

zaednasr commented Aug 7, 2024

@MulverineX it was the alternate domains. I added them on youtube and tiktok, disabled them from rvx and added them in the app and they opened up as expected.

@zaednasr zaednasr added the Waiting For Release Implemented but not released yet label Aug 11, 2024
@zaednasr zaednasr closed this as completed Sep 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Waiting For Release Implemented but not released yet
Projects
None yet
Development

No branches or pull requests

3 participants