Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

支付宝账单中交易状态关闭的订单，标记为未入账 #51

Closed
wants to merge 2 commits into from
Closed

支付宝账单中交易状态关闭的订单，标记为未入账 #51

wants to merge 2 commits into from

Conversation

CyrivlClth
Copy link

Closes: #44

gaocegege
gaocegege approved these changes Feb 9, 2022
View reviewed changes
Copy link
Member

@gaocegege gaocegege left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/cc @Triple-Z

@gaocegege
Copy link
Member

Please fix the unit test.

Triple-Z
Triple-Z requested changes Feb 9, 2022
View reviewed changes
pkg/compiler/beancount/template.go
PayTime time.Time
PayTime time.Time
// 未入账标记
Pending bool
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

注释可以写在代码行后面。

Pending bool  // comment

pkg/ir/ir.go
Item string
Category string
// 是否未入账
Pending bool
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

注释可以写在代码行后面。

@Triple-Z
Copy link
Member

Triple-Z commented Feb 9, 2022 •
edited
Loading

建议提供一个配置选项，可以直接忽略 pending ，直接输出为 * 。

例：

alipay:
  txClosedPending: false
  rules:
    # ...

/cc @gaocegege

@CyrivlClth CyrivlClth closed this Feb 14, 2022
@saccohuo
Copy link

saccohuo commented Oct 5, 2022

这个PR有合并吗，现在导出的还是有一堆”交易关闭“的item

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Triple-Z Triple-Z Triple-Z requested changes

@gaocegege gaocegege gaocegege approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

关于 There is a mole, The tx is canceled.
4 participants
@CyrivlClth @gaocegege @Triple-Z @saccohuo