Merge pull request #265 from dataiku/feature/dss110-sc-99387-missing-govern-node-type-in-fm-client-api

99387 : support creating a govern node

Author: ericcournarie

Diff for: dataikuapi/fm/instances.py

@@ -15,7 +15,7 @@ def __init__(
         self, client, label, instance_settings_template_id, virtual_network_id, image_id
     ):
         """
-        Helper to create a DSS Instance
+        Helper to create a DSS instance.
 
         :param client: The FM client
         :type client: :class:`dataikuapi.fm.fmclient`
@@ -36,16 +36,17 @@ def __init__(
 
     def with_dss_node_type(self, dss_node_type):
         """
-        Set the DSS Node type of the instance to create
+        Set the DSS node type of the instance to create. The default node type is `DESIGN`.
 
-        :param str dss_node_type: Optional , the type of the dss node to create. Supports "design", "automation" or "deployer". Defaults to "design"
+        :param dss_node_type: the type of the dss node to create.
+        :type dss_node_type: :class:`dataikuapi.fm.instances.FMNodeType`
         :rtype: :class:`dataikuapi.fm.instances.FMInstanceCreator`
         """
-        if dss_node_type not in ["design", "automation", "deployer"]:
-            raise ValueError(
-                'Only "design", "automation" or "deployer" dss_node_type are supported'
-            )
-        self.data["dssNodeType"] = dss_node_type
+        # backward compatibility, was a string before . be sure the value falls into the enum
+        value = dss_node_type;
+        if isinstance(dss_node_type, str):
+            value = FMNodeType[dss_node_type.upper()]
+        self.data["dssNodeType"] = value.value
         return self
 
     def with_cloud_instance_type(self, cloud_instance_type):
@@ -399,6 +400,11 @@ def set_public_ip(self, enable, public_ip_id):
         self.instance_data["gcpPublicIPId"] = public_ip_id
         return self
 
+class FMNodeType(Enum):
+    DESIGN = "design"
+    DEPLOYER = "deployer"
+    AUTOMATION = "automation"
+    GOVERN = "govern"
 
 class FMInstanceEncryptionMode(Enum):
     NONE = "NONE"

Diff for: dataikuapi/fm/virtualnetworks.py

@@ -181,7 +181,7 @@ def delete(self):
         return FMFuture.from_resp(self.client, future)
 
     def set_fleet_management(
-        self, enable, event_server=None, deployer_management="NO_MANAGED_DEPLOYER"
+        self, enable, event_server=None, deployer_management="NO_MANAGED_DEPLOYER", govern_server=None
     ):
         """
         When enabled, all instances in this virtual network know each other and can centrally manage deployer and logs centralization
@@ -193,12 +193,14 @@ def set_fleet_management(
             - "NO_MANAGED_DEPLOYER": Do not manage the deployer. This is the default mode.
             - "CENTRAL_DEPLOYER": Central deployer. Recommended if you have more than one design node or may have more than one design node in the future.
             - "EACH_DESIGN_NODE": Deployer from design. Recommended if you have a single design node and want a simpler setup.
+        :param str govern_server: Optional, node name of the node that should act as the centralized Govern server.
 
         """
 
         self.vn_data["managedNodesDirectory"] = enable
         self.vn_data["eventServerNodeLabel"] = event_server
         self.vn_data["nodesDirectoryDeployerMode"] = deployer_management
+        self.vn_data["governServerNodeLabel"] = govern_server
         return self
 
     def set_https_strategy(self, https_strategy):