Skip to content

asarray is not strict enough #118

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
lucascolley opened this issue Jan 4, 2025 · 1 comment · Fixed by #147
Closed

asarray is not strict enough #118

lucascolley opened this issue Jan 4, 2025 · 1 comment · Fixed by #147
Milestone
2.4

Comments

@lucascolley
Copy link
Member

lucascolley commented Jan 4, 2025 •
edited
Loading

The spec requires asarray to support "a (possibly nested) sequence of Python scalars", but not nested sequences of arrays.

https://data-apis.org/array-api/draft/API_specification/generated/array_api.asarray.html
@lucascolley lucascolley mentioned this issue Jan 4, 2025
Merged
@ev-br ev-br mentioned this issue Mar 28, 2025
Open
@ev-br
Copy link
Member

ev-br commented Mar 28, 2025

This just came up in #70 (comment), motivated by scikit-learn adoption work.

AFAICS, it is indeed unspecified in the spec and inconsistent across array libraries. Thus:

@ev-br ev-br mentioned this issue Mar 28, 2025
Open
@ev-br ev-br mentioned this issue Apr 9, 2025
Merged
@ev-br ev-br added this to the 2.4 milestone Apr 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.4
Development

Successfully merging a pull request may close this issue.

BUG: do not allow asarray of nested sequences of arrays ev-br/array-api-strict
2 participants
@ev-br @lucascolley