Returned value of makeHTTPDriver() doesn't typecheck when passed two arguments

[Javran]

Code to reproduce the issue:

for @cycle/http:

http = makeHTTPDriver()(request$, 'fooHttp')

Expected behavior:

This should typecheck.

Actual behavior:

This doesn't typecheck as makeHTTPDriver() returns a function expecting exactly one argument but passed two instead.

Versions of packages used:

@cycle/http@15.4.0

For anyone come across this, my current workaround is to give drive a more accurate type:

 const driver: ((stream: Stream<RequestInput>, name?: string) => HTTPSource) =
      (makeHTTPDriver() as any)
 http = driver(request$, 'fooHttp')

[staltz]

Hi @Javran, could you share a bit more of the surrounding context where you are using this? In the vast majority of use cases, the driver function itself shouldn't be called directly, but it's Cycle.js run which calls the driver, and the types in @cycle/http are optimized to satisfy @cycle/run's typechecking when calling run.

[Javran]

@staltz I'm trying to have a working starter template project with typescript setup (btw frustratingly, there aren't many around and all of them are bitrot one way or another) and came across https://github.com/cyclejs-community/typescript-starter-cycle/blob/c47fbd5a3a54fe3f5627e4a0bbce86223b101b99/src/drivers/github.ts#L43 (which is the context here) while trying to update the dependencies to latest version. Admittedly I don't know much about cyclejs (yet!), so I'm just following the type to see what's going on.

[jvanbruegge]

I've briefly looked over the code and the github source is not how one would write this today. Usually you would write a main wrapper similar to @cycle/state that just uses the normal http driver. At the moment sadly do not have the time to change that repo.