Skip to content

Commit 75c9f56

Browse files
SCrockySCrocky
authored and
SCrocky
committed
refactor(Commit): Added deprecation on git signoff mechanic
Signoff dedicated code is no longer necessary & removed #TODO as tests show identical args and extra-args are not an issue.
1 parent 37a118e commit 75c9f56

File tree

2 files changed

+1
-1
lines changed

2 files changed

+1
-1
lines changed

commitizen/cli.py

-1
Original file line numberDiff line numberDiff line change
@@ -434,7 +434,6 @@ def main():
434434
raise InvalidCommandArgumentError(
435435
f"Invalid commitizen arguments were found before -- separator: `{' '.join(unknown_args[:pos])}`. "
436436
)
437-
# TODO: treat case when extra-args and commitizen args are identical
438437
extra_args = " ".join(unknown_args[1:])
439438
arguments["extra_cli_args"] = extra_args
440439

commitizen/commands/commit.py

+1
Original file line numberDiff line numberDiff line change
@@ -91,6 +91,7 @@ def __call__(self):
9191
signoff: bool = self.arguments.get("signoff")
9292

9393
if signoff:
94+
out.warn("signoff mechanic is deprecated, please use `cz commit -- -s` instead.")
9495
c = git.commit(m, "-s")
9596

9697
if self.arguments.get("extra_cli_args"):

0 commit comments

Comments
 (0)