Merge pull request shakacode#29 from justin808/rubocop-integration

Added RuboCop Checking.

```
bin/lint                                                                                                                                                             ✹ [14:16:35]
Linting with Rubocop
Inspecting 32 files
................................

32 files inspected, no offenses detected
Linting with ruby-lint
/Users/justin/j/react/react-webpack-rails-tutorial/client/node_modules/bootstrap-sass/tasks/converter/less_conversion.rb:W:299:22: ambiguous first argument; put parentheses or a space even after the operator
Linting with eslint and jscs

> [email protected] jscs /Users/justin/j/react/react-webpack-rails-tutorial/client
> jscs --verbose .

No code style errors found.
```

Author: justin808

.rubocop.yml

@@ -0,0 +1,20 @@
+# This is the configuration used to check the rubocop source code.
+
+AllCops:
+  Exclude:
+    - 'vendor/**/*'
+    - 'spec/fixtures/**/*'
+    - 'node_modules/**/*'
+    - 'db/schema.rb'
+    - 'db/seeds.rb'
+    - 'client/node_modules/**/*'
+    - 'bin/**/*'
+
+Metrics/LineLength:
+  Max: 120
+
+Style/StringLiterals:
+  EnforcedStyle: double_quotes
+
+Style/Documentation:
+  Enabled: false

Gemfile

@@ -1,73 +1,76 @@
-source 'https://rubygems.org'
+source "https://rubygems.org"
 ruby "2.1.5"
 
 #
-# Bundle edge Rails instead: gem 'rails', github: 'rails/rails'
-gem 'rails', '~>4.2'
+# Bundle edge Rails instead: gem "rails", github: "rails/rails"
+gem "rails", "~>4.2"
 # Use sqlite3 as the database for Active Record
-gem 'sqlite3', group: :development
-gem 'pg', group: :production
+gem "sqlite3", group: :development
+gem "pg", group: :production
 
 # Use SCSS for stylesheets
-gem 'sass-rails'
-gem 'bootstrap-sass', '~> 3.3.1'
+gem "sass-rails"
+gem "bootstrap-sass", "~> 3.3.1"
 # Use Uglifier as compressor for JavaScript assets
-gem 'uglifier'
+gem "uglifier"
 # Use CoffeeScript for .js.coffee assets and views
-gem 'coffee-rails'
+gem "coffee-rails"
 # See https://github.com/sstephenson/execjs#readme for more supported runtimes
-# gem 'therubyracer', platforms: :ruby
+# gem "therubyracer", platforms: :ruby
 
 # Use jquery as the JavaScript library
-gem 'jquery-rails'
+gem "jquery-rails"
 # Turbolinks makes following links in your web application faster. Read more: https://github.com/rails/turbolinks
-gem 'turbolinks'
+gem "turbolinks"
 # Build JSON APIs with ease. Read more: https://github.com/rails/jbuilder
-gem 'jbuilder'
+gem "jbuilder"
 # bundle exec rake doc:rails generates the API under doc/api.
-gem 'sdoc', group: :doc
+gem "sdoc", group: :doc
 
 # Use ActiveModel has_secure_password
-# gem 'bcrypt', '~> 3.1.7'
+# gem "bcrypt", "~> 3.1.7"
 
 # Use Rails Html Sanitizer for HTML sanitization
-gem 'rails-html-sanitizer'
+gem "rails-html-sanitizer"
 
 # Use Unicorn as the app server
-gem 'unicorn'
+gem "unicorn"
 
-gem 'autoprefixer-rails'
+gem "autoprefixer-rails"
 
 # Use Capistrano for deployment
-# gem 'capistrano-rails', group: :development
+# gem "capistrano-rails", group: :development
 group :production do
-  gem 'rails_12factor'
+  gem "rails_12factor"
 end
 
-
 group :development, :test do
-  # Call 'debugger' anywhere in the code to stop execution and get a debugger console
-  gem 'byebug'
+  # Call "debugger" anywhere in the code to stop execution and get a debugger console
+  gem "byebug"
 
   # Access an IRB console on exceptions page and /console in development
-  gem 'web-console', '~> 2.0.0.beta2'
+  gem "web-console", "~> 2.0.0.beta2"
 
   # Spring speeds up development by keeping your application running in the background. Read more: https://github.com/rails/spring
-  gem 'spring'
+  gem "spring"
 
   # Manage application processes
-  gem 'foreman'
+  gem "foreman"
+
+  gem "factory_girl_rails"
+
+  gem "rubocop", require: false
 
-  gem 'factory_girl_rails'
+  gem "ruby-lint", require: false
 end
 
-gem 'spring-commands-rspec', group: :development
+gem "spring-commands-rspec", group: :development
 
 group :test  do
-  gem 'rspec-rails'
-  gem 'capybara'
-  gem 'capybara-screenshot'
-  gem 'capybara-webkit'
-  gem 'database_cleaner'
-  gem 'launchy'
+  gem "rspec-rails"
+  gem "capybara"
+  gem "capybara-screenshot"
+  gem "capybara-webkit"
+  gem "database_cleaner"
+  gem "launchy"
 end

Gemfile.lock

@@ -38,6 +38,9 @@ GEM
       tzinfo (~> 1.1)
     addressable (2.3.7)
     arel (6.0.0)
+    ast (2.0.0)
+    astrolabe (1.3.0)
+      parser (>= 2.2.0.pre.3, < 3.0)
     autoprefixer-rails (5.1.8)
       execjs
       json
@@ -106,7 +109,10 @@ GEM
     multi_json (1.11.0)
     nokogiri (1.6.6.2)
       mini_portile (~> 0.6.0)
+    parser (2.2.0.3)
+      ast (>= 1.1, < 3.0)
     pg (0.18.1)
+    powerpack (0.1.0)
     rack (1.6.0)
     rack-test (0.6.3)
       rack (>= 1.0)
@@ -139,6 +145,7 @@ GEM
       activesupport (= 4.2.1)
       rake (>= 0.8.7)
       thor (>= 0.18.1, < 2.0)
+    rainbow (2.0.0)
     raindrops (0.13.0)
     rake (10.4.2)
     rdoc (4.2.0)
@@ -160,6 +167,16 @@ GEM
       rspec-mocks (~> 3.2.0)
       rspec-support (~> 3.2.0)
     rspec-support (3.2.2)
+    rubocop (0.29.1)
+      astrolabe (~> 1.3)
+      parser (>= 2.2.0.1, < 3.0)
+      powerpack (~> 0.1)
+      rainbow (>= 1.99.1, < 3.0)
+      ruby-progressbar (~> 1.4)
+    ruby-lint (2.0.3)
+      parser (~> 2.1, >= 2.1.1)
+      slop (~> 3.4, >= 3.4.7)
+    ruby-progressbar (1.7.5)
     sass (3.4.13)
     sass-rails (5.0.1)
       railties (>= 4.0.0, < 5.0)
@@ -170,6 +187,7 @@ GEM
     sdoc (0.4.1)
       json (~> 1.7, >= 1.7.7)
       rdoc (~> 4.0)
+    slop (3.6.0)
     spring (1.3.3)
     spring-commands-rspec (1.0.4)
       spring (>= 0.9.1)
@@ -227,6 +245,8 @@ DEPENDENCIES
   rails-html-sanitizer
   rails_12factor
   rspec-rails
+  rubocop
+  ruby-lint
   sass-rails
   sdoc
   spring

Rakefile

@@ -1,6 +1,10 @@
 # Add your own tasks in files placed in lib/tasks ending in .rake,
 # for example lib/tasks/capistrano.rake, and they will automatically be available to Rake.
 
-require File.expand_path('../config/application', __FILE__)
+require File.expand_path("../config/application", __FILE__)
 
 Rails.application.load_tasks
+
+require "rubocop/rake_task"
+
+RuboCop::RakeTask.new

app/controllers/comments_controller.rb

@@ -28,7 +28,7 @@ def create
 
     respond_to do |format|
       if @comment.save
-        format.html { redirect_to @comment, notice: 'Comment was successfully created.' }
+        format.html { redirect_to @comment, notice: "Comment was successfully created." }
         format.json { render :show, status: :created, location: @comment }
       else
         format.html { render :new }
@@ -42,7 +42,7 @@ def create
   def update
     respond_to do |format|
       if @comment.update(comment_params)
-        format.html { redirect_to @comment, notice: 'Comment was successfully updated.' }
+        format.html { redirect_to @comment, notice: "Comment was successfully updated." }
         format.json { render :show, status: :ok, location: @comment }
       else
         format.html { render :edit }
@@ -56,19 +56,20 @@ def update
   def destroy
     @comment.destroy
     respond_to do |format|
-      format.html { redirect_to comments_url, notice: 'Comment was successfully destroyed.' }
+      format.html { redirect_to comments_url, notice: "Comment was successfully destroyed." }
       format.json { head :no_content }
     end
   end
 
   private
-    # Use callbacks to share common setup or constraints between actions.
-    def set_comment
-      @comment = Comment.find(params[:id])
-    end
 
-    # Never trust parameters from the scary internet, only allow the white list through.
-    def comment_params
-      params.require(:comment).permit(:author, :text)
-    end
+  # Use callbacks to share common setup or constraints between actions.
+  def set_comment
+    @comment = Comment.find(params[:id])
+  end
+
+  # Never trust parameters from the scary internet, only allow the white list through.
+  def comment_params
+    params.require(:comment).permit(:author, :text)
+  end
 end

client/.eslintrc

@@ -125,7 +125,7 @@ rules:
   key-spacing: [2, {beforeColon: false, afterColon: true}]
   max-depth: [1, 4]
   # Different from 80 chars of AirBnb Javascript
-  max-len: [2, 100]
+  max-len: [2, 120]
   max-nested-callbacks: [1, 2]
   max-params: [1, 4]
   max-statements: [0, 10]

client/assets/javascripts/components/CommentBox.jsx

@@ -9,10 +9,6 @@ import FormStore from '../stores/FormStore';
 import CommentActions from '../actions/CommentActions';
 import FormActions from '../actions/FormActions';
 
-// Next line is necessary for exposing React to browser for
-// the React Developer Tools: http://facebook.github.io/react/blog/2014/01/02/react-chrome-developer-tools.html
-// require("expose?React!react");
-
 var CommentBox = React.createClass({
   displayName: 'CommentBox',
 

client/assets/stylesheets/_bootstrap-variables-customization.scss

@@ -31,8 +31,3 @@ $image-url-path: "/assets/images/" !default;
     @return url("#{$image-url-path}#{$image}");
   }
 }
-
-//$image-url-path: "../images/" !default;
-//@function image-url($url) {
-//  @return url("#{$image-url-path}#{$url}");
-//}

client/bin/lint

@@ -1,4 +1,3 @@
 #!/bin/sh
 find . -path ./node_modules -prune -o -name "*.js" -o -name "*.jsx" -exec eslint {} \;
 npm run jscs .
-

client/jetbrains/Inspection_RailsOnMaui_Default.xml

@@ -59,6 +59,7 @@
   <inspection_tool class="JSJQueryEfficiency" enabled="false" level="WARNING" enabled_by_default="false" />
   <inspection_tool class="JSUnresolvedLibraryURL" enabled="false" level="WARNING" enabled_by_default="false" />
   <inspection_tool class="JSUnusedGlobalSymbols" enabled="false" level="WARNING" enabled_by_default="false" />
+  <inspection_tool class="Jscs" enabled="true" level="ERROR" enabled_by_default="true" />
   <inspection_tool class="LabeledStatementJS" enabled="true" level="WARNING" enabled_by_default="true" />
   <inspection_tool class="LessResolvedByNameOnly" enabled="false" level="WEAK WARNING" enabled_by_default="false" />
   <inspection_tool class="LessUnresolvedMixin" enabled="false" level="WARNING" enabled_by_default="false" />

client/package.json

@@ -62,7 +62,7 @@
     "test": "echo \"Error: no test specified\" && exit 1",
     "start": "node server.js",
     "gulp": "gulp",
-    "jscs": "jscs",
+    "jscs": "jscs --verbose",
     "eslint": "eslint"
   }
 }

config/application.rb

@@ -1,6 +1,6 @@
-require File.expand_path('../boot', __FILE__)
+require File.expand_path("../boot", __FILE__)
 
-require 'rails/all'
+require "rails/all"
 
 # Require the gems listed in Gemfile, including any gems
 # you've limited to :test, :development, or :production.
@@ -14,16 +14,16 @@ class Application < Rails::Application
 
     # Set Time.zone default to the specified zone and make Active Record auto-convert to this zone.
     # Run "rake -D time" for a list of tasks for finding time zone names. Default is UTC.
-    # config.time_zone = 'Central Time (US & Canada)'
+    # config.time_zone = "Central Time (US & Canada)"
 
     # The default locale is :en and all translations from config/locales/*.rb,yml are auto loaded.
-    # config.i18n.load_path += Dir[Rails.root.join('my', 'locales', '*.{rb,yml}').to_s]
+    # config.i18n.load_path += Dir[Rails.root.join("my", "locales", "*.{rb,yml}").to_s]
     # config.i18n.default_locale = :de
 
     # For not swallow errors in after_commit/after_rollback callbacks.
     config.active_record.raise_in_transactional_callbacks = true
 
     # Add client/assets/stylesheets to asset pipeline's search path.
-    config.assets.paths << Rails.root.join("client", "assets" ,"stylesheets")
+    config.assets.paths << Rails.root.join("client", "assets", "stylesheets")
   end
 end

config/boot.rb

@@ -1,3 +1,3 @@
-ENV['BUNDLE_GEMFILE'] ||= File.expand_path('../../Gemfile', __FILE__)
+ENV["BUNDLE_GEMFILE"] ||= File.expand_path("../../Gemfile", __FILE__)
 
-require 'bundler/setup' # Set up gems listed in the Gemfile.
+require "bundler/setup" # Set up gems listed in the Gemfile.

config/database.yml

@@ -2,7 +2,7 @@
 #   gem install sqlite3
 #
 #   Ensure the SQLite 3 gem is defined in your Gemfile
-#   gem 'sqlite3'
+#   gem "sqlite3"
 #
 default: &default
   adapter: sqlite3

config/environment.rb

@@ -1,5 +1,5 @@
 # Load the Rails application.
-require File.expand_path('../application', __FILE__)
+require File.expand_path("../application", __FILE__)
 
 # Initialize the Rails application.
 Rails.application.initialize!

config/environments/development.rb

@@ -10,7 +10,7 @@
   config.eager_load = false
 
   # Show full error reports and disable caching.
-  config.consider_all_requests_local       = true
+  config.consider_all_requests_local = true
   config.action_controller.perform_caching = false
 
   # Don't care if the mailer can't send.
@@ -27,7 +27,7 @@
   # number of complex assets.
   config.assets.debug = true
 
-  # Asset digests allow you to set far-future HTTP expiration dates on all assets, 
+  # Asset digests allow you to set far-future HTTP expiration dates on all assets,
   # yet still be able to expire them through the digest params.
   config.assets.digest = true