WIP

Author: justin808

spec/rails_helper.rb

@@ -49,11 +49,11 @@
   # Using errors_ok as there is a timing issue causing crashes without this setting
   # https://github.com/teampoltergeist/poltergeist/issues/830
 
-  default_driver = :selenium_chrome
+  default_driver = :selenium_chrome_headless
 
   supported_drivers = %i[ poltergeist poltergeist_errors_ok
                           poltergeist_no_animations webkit
-                          selenium_chrome selenium_firefox selenium]
+                          selenium_chrome selenium_chrome_headless selenium_firefox selenium]
   driver = ENV["DRIVER"].try(:to_sym) || default_driver
   Capybara.default_driver = driver
 
@@ -95,7 +95,7 @@
       js_driver.render(path, full: true)
     end
 
-  when :selenium_chrome
+  when :selenium_chrome, :selenium_chrome_headless
     DriverRegistration.register_selenium_chrome
   when :selenium_firefox, :selenium
     DriverRegistration.register_selenium_firefox
@@ -185,7 +185,7 @@ def js_errors_driver
   end
 
   def js_selenium_driver
-    driver = Capybara.javascript_driver == :selenium_firefox ? :selenium_firefox : :selenium_chrome
+    driver = Capybara.javascript_driver == :selenium_firefox ? :selenium_firefox : :selenium_chrome_headless
     if driver == :selenium_firefox
       DriverRegistration.register_selenium_firefox
     else

spec/support/driver_registration.rb

@@ -2,6 +2,10 @@ module DriverRegistration
   def self.register_selenium_chrome
     return if @selenium_chrome_registered
     Capybara.register_driver :selenium_chrome do |app|
+      Capybara::Selenium::Driver.new(app,
+                                     browser: :chrome)
+    end
+    Capybara.register_driver :selenium_chrome_headless do |app|
       capabilities = Selenium::WebDriver::Remote::Capabilities.chrome(
         chromeOptions: { args: %w[headless disable-gpu] }
       )

spec/support/poltergeist.rb

@@ -0,0 +1,48 @@
+RSpec.configure do |config|
+  config.after(:each, :js) do
+    next unless [:selenium_chrome, :selenium_chrome_headless].include?(Capybara.current_driver)
+
+    errors = []
+
+    page.driver.browser.manage.logs.get(:browser).each do |entry|
+      next if entry.message =~ /Download the React DevTools for a better development experience/
+
+      # Chrome doesn't allow suppressing log entries for network responses with statuses >= 400 (even if this is valid
+      # api behaviour) and always show them in log as SEVERE errors prior to any js error resolving. Some info here:
+      # https://bugs.chromium.org/p/chromium/issues/detail?id=677599
+      # https://bugs.chromium.org/p/chromium/issues/detail?id=124534
+      # https://bugs.chromium.org/p/chromium/issues/detail?id=96212
+      # This doesn't skips unhandled js errors which should be properly catched
+      next if @skipped_chrome_network_errors&.any? do |e|
+        entry.message.include? \
+          "#{e[:path]} - Failed to load resource: the server responded with a status of #{e[:status]}"
+      end
+
+      # needs external mock server for selenium
+      if entry.message =~ /res.cloudinary.com/
+        puts entry.message
+        next
+      end
+
+      # several places SLV
+      if entry.message =~ /"Warning: Text content did not match. Server: \\"1000\\" Client: \\"1,000\\""/
+        puts entry.message
+        next
+      end
+
+      pretty_message = if entry.message =~ %r{http://(127.0.0.1|app.lvh.me)[^ ]+ [\d:]+ }
+                         entry.message[/[^ ]+ [^ ]+ (.*)$/, 1]&.gsub(/\A"|"\Z/, "")&.gsub(/\\n/, "\n")
+                       else
+                         entry.message
+                       end
+
+      %w[DEBUG INFO WARNING].include?(entry.level) ? puts(pretty_message) : errors << pretty_message
+    end
+
+    page.driver.browser.manage.logs.get(:driver).each do |entry|
+      %w[DEBUG INFO WARNING].include?(entry.level) ? puts(entry.message) : errors << entry.message
+    end
+
+    raise("Java Script Error(s) on the page:\n\n" + errors.join("\n")) if errors.present?
+  end
+end