Skip to content

Commit d333fa7

Browse files
committed
Fixing references among procfiles & in README
1 parent 3732af4 commit d333fa7

File tree

3 files changed

+7
-8
lines changed

3 files changed

+7
-8
lines changed

Procfile.dev

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
# Basic procfile for dev work.
22
# Runs all processes. Development is faster if you pick one of the other Procfiles if you don't need
3-
# some of the processes: Procfile.rails or Procfile.express
3+
# some of the processes: Procfile.hot or Procfile.express
44

55
# Development rails requires both rails and rails-assets
66
# (and rails-server-assets if server rendering)

Procfile.hot

+2-3
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
1-
# Basic procfile for dev work.
2-
# Runs all processes. Development is faster if you pick one of the other Procfiles if you don't need
3-
# some of the processes: Procfile.rails or Procfile.express
1+
# Basic procfile for rails-related part of dev processes
2+
# using a webpack development server to load JavaScript and CSS
43

54
# Development rails requires both rails and rails-assets
65
# (and rails-server-assets if server rendering)

README.md

+4-4
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ By Justin Gordon and the Shaka Code Team, [www.shakacode.com](http://www.shakaco
1818
- Check out the [react_on_rails gem](https://github.com/shakacode/react_on_rails) for easy webpack integration.
1919
- If you came to here from the blog article, this example project has evolved. See [merged pull requests](https://github.com/shakacode/react-webpack-rails-tutorial/pulls?utf8=%E2%9C%93&q=is%3Apr+is%3Amerged) and the [CHANGELOG.md](./CHANGELOG.md).
2020

21-
An outdated full tutorial article behind of the motivation of this system can be found at: [Fast Rich Client Rails Development With Webpack and the ES6 Transpiler](http://www.railsonmaui.com/blog/2014/10/03/integrating-webpack-and-the-es6-transpiler-into-an-existing-rails-project/). Note, this source code repository is way ahead of the tutorial.
21+
An outdated full tutorial article behind of the motivation of this system can be found at: [Fast Rich Client Rails Development With Webpack and the ES6 Transpiler](http://www.railsonmaui.com/blog/2014/10/03/integrating-webpack-and-the-es6-transpiler-into-an-existing-rails-project/). Note, this source code repository is way ahead of the tutorial.
2222

2323
# NEWS
2424
We have not yet updated the `react_on_rails` gem generators for the following tasks. We're looking for help to migrate this, if you're interested in contributing to the project. *The tutorial* refers to this repo. The following changes have resulted in lots of differences for the webpack files and visual assets:
@@ -78,10 +78,10 @@ See package.json and Gemfile for versions
7878
1. `rake db:setup`
7979
1. `foreman start -f Procfile.hot`
8080
1. Open a browser tab to http://localhost:3000 for the Rails app example with HOT RELOADING
81-
2. Try Hot Reloading steps below!
81+
2. Try Hot Reloading steps below!
8282
1. `foreman start -f Procfile.express`
8383
1. Open a browser tab to http://localhost:4000 for the Hot Module Replacement Example just using an express server (no Rails involved). This is good for fast prototyping of React components. However, this setup is not as useful now that we have hot reloading working for Rails!
84-
2. Try Hot Reloading steps below!
84+
2. Try Hot Reloading steps below!
8585
1. `foreman start -f Procfile.static`
8686
1. Open a browser tab to http://localhost:3000 for the Rails app example.
8787
2. When you make changes, you have to refresh the browser page.
@@ -95,7 +95,7 @@ See package.json and Gemfile for versions
9595
1. Run all linters and tests: `rake`
9696
1. See all npm commands: `npm run`
9797
1. Start all development processes: `foreman start -f Procfile.dev`
98-
1. Start all Rails only development processes: `foreman start -f Procfile.rails`
98+
1. Start all Rails only development processes: `foreman start -f Procfile.hot`
9999
1. Start development without Rails, using the Webpack Dev Server only: `npm start` (or `foreman start -f Procfile.express`)
100100

101101

0 commit comments

Comments
 (0)