Update lint dependencies and configure for project

Author: Andrew Ralston

Diff for: client/.eslintrc.yml

@@ -24,6 +24,10 @@ rules:
   indent: [1, 2, { SwitchCase: 1, VariableDeclarator: 2 }]
   id-length: [1, { min: 2, exceptions: [_, e, i, k, v] }]
   space-before-function-paren: [1, "never"]
+  no-underscore-dangle: 0
+
+  ### Imports
+  import/no-unresolved: 0
 
   ### React
   jsx-quotes: [1, prefer-double]

Diff for: client/app/bundles/comments/reducers/index.js

@@ -1,5 +1,4 @@
-import commentsReducer from './commentsReducer';
-import { $$initialState as $$commentsState } from './commentsReducer';
+import commentsReducer, { $$initialState as $$commentsState } from './commentsReducer';
 
 export default {
   $$commentsStore: commentsReducer,

Diff for: client/app/bundles/comments/startup/ClientApp.jsx

@@ -7,8 +7,8 @@ import NonRouterCommentsContainer from '../containers/NonRouterCommentsContainer
 export default props => {
   const store = createStore(props);
   return (
-      <Provider store={store}>
-        <NonRouterCommentsContainer />
-      </Provider>
+    <Provider store={store}>
+      <NonRouterCommentsContainer />
+    </Provider>
   );
 };

Diff for: client/app/bundles/comments/startup/ServerApp.jsx

@@ -7,8 +7,8 @@ import NonRouterCommentsContainer from '../containers/NonRouterCommentsContainer
 export default props => {
   const store = createStore(props);
   return (
-      <Provider store={store}>
-        <NonRouterCommentsContainer />
-      </Provider>
+    <Provider store={store}>
+      <NonRouterCommentsContainer />
+    </Provider>
   );
 };

Diff for: client/app/bundles/comments/store/commentsStore.js

@@ -1,8 +1,7 @@
 import { compose, createStore, applyMiddleware, combineReducers } from 'redux';
 import thunkMiddleware from 'redux-thunk';
 import loggerMiddleware from 'libs/middlewares/loggerMiddleware';
-import reducers from '../reducers';
-import { initialStates } from '../reducers';
+import reducers, { initialStates } from '../reducers';
 
 export default props => {
   const initialComments = props.comments;

Diff for: client/app/bundles/comments/store/routerCommentsStore.js

@@ -1,9 +1,8 @@
 import { applyMiddleware, compose, createStore, combineReducers } from 'redux';
 import thunkMiddleware from 'redux-thunk';
 import loggerMiddleware from 'libs/middlewares/loggerMiddleware';
-import reducers from '../reducers';
+import reducers, { initialStates } from '../reducers';
 import { routerReducer } from 'react-router-redux';
-import { initialStates } from '../reducers';
 
 export default props => {
   const initialComments = props.comments;

Diff for: client/app/libs/middlewares/loggerMiddleware.js

@@ -10,13 +10,13 @@ export default function logger({ getState }) {
     // We can't _read_ immutable objects in console out-of-the-box.
     const state = getState();
     const readableState = {};
-    for (const storeItem in state) {
-      if (state.hasOwnProperty(storeItem)) {
-        readableState[storeItem] = (
-          state[storeItem].toJS ? state[storeItem].toJS() : state[storeItem]
-        );
-      }
-    }
+
+    Object.keys(state).forEach(storeItem => {
+      readableState[storeItem] = (
+        state[storeItem].toJS ? state[storeItem].toJS() : state[storeItem]
+      );
+      return;
+    });
 
     console.log('state after dispatch', readableState);
 

Diff for: client/app/libs/testHelper.js

@@ -12,12 +12,10 @@ global.window = win;
 
 // from mocha-jsdom https://github.com/rstacruz/mocha-jsdom/blob/master/index.js#L80
 function propagateToGlobal(window) {
-  for (const key in window) {
-    if (!window.hasOwnProperty(key)) continue;
-    if (key in global) continue;
-
+  Object.keys(window).forEach(key => {
+    if (key in global) return;
     global[key] = window[key];
-  }
+  });
 }
 
 // take all properties of the window object and also attach it to the

Diff for: client/package.json

@@ -94,9 +94,11 @@
     "body-parser": "^1.15.0",
     "chai": "^3.5.0",
     "chai-immutable": "^1.5.4",
-    "eslint": "^2.7.0",
-    "eslint-config-shakacode": "^4.0.0",
-    "eslint-plugin-react": "^4.3.0",
+    "eslint": "^2.10.1",
+    "eslint-config-shakacode": "^5.0.0",
+    "eslint-plugin-import": "^1.8.0",
+    "eslint-plugin-jsx-a11y": "^1.2.0",
+    "eslint-plugin-react": "^5.1.1",
     "estraverse-fb": "^1.3.1",
     "express": "^4.13.4",
     "pug": "^2.0.0-alpha3",