Switch to RSpec's implicit shared context via metadata

Author: robwise

spec/features/add_new_comment_spec.rb

@@ -3,40 +3,31 @@
 require "features/shared/contexts"
 
 feature "Add new comment" do
-  context "from main page", js: true do
-    include_context "Main Page"
-    context "via Horizontal Form" do
-      include_context "Horizontal Form"
+  context "from main page", page: :main, js: true do
+    context "via Horizontal Form", form: :horizontal do
       include_examples "New Comment Submission"
     end
-    context "via Inline Form" do
-      include_context "Inline Form"
+    context "via Inline Form", form: :inline do
       include_examples "New Comment Submission"
     end
-    context "via Stacked Form" do
-      include_context "Stacked Form"
+    context "via Stacked Form", form: :stacked do
       include_examples "New Comment Submission"
     end
   end
 
-  context "from simple page", js: true do
-    include_context "Simple Page"
-    context "via Horizontal Form" do
-      include_context "Horizontal Form"
+  context "from simple page", page: :simple, js: true do
+    context "via Horizontal Form", form: :horizontal do
       include_examples "New Comment Submission"
     end
-    context "via Inline Form" do
-      include_context "Inline Form"
+    context "via Inline Form", form: :inline do
       include_examples "New Comment Submission"
     end
-    context "via the Stacked Form" do
-      include_context "Stacked Form"
+    context "via the Stacked Form", form: :stacked do
       include_examples "New Comment Submission"
     end
   end
 
-  context "from classic page" do
-    include_context "Classic Page"
+  context "from classic page", page: :classic do
     background { click_link "New Comment" }
     include_examples "New Comment Submission"
   end

spec/features/destroy_comment_spec.rb

@@ -1,10 +1,8 @@
 require "rails_helper"
 require "features/shared/contexts"
 
-feature "Destroy a comment" do
-  include_context "Existing Comment"
-  context "from classic page" do
-    include_context "Classic Page"
+feature "Destroy a comment", existing_comment: true do
+  context "from classic page", page: :classic do
     let(:comment) { Comment.first }
 
     scenario "clicking destroy link destroys comment" do

spec/features/edit_comment_spec.rb

@@ -2,12 +2,10 @@
 require "features/shared/examples"
 require "features/shared/contexts"
 
-feature "Edit a comment" do
-  include_context "Existing Comment"
+feature "Edit a comment", existing_comment: true do
   let(:comment) { Comment.first }
 
-  context "from classic page" do
-    include_context "Classic Page"
+  context "from classic page", page: :classic do
     background { click_link "Edit", match: :first }
 
     context "when edit is submitted" do
@@ -20,9 +18,7 @@
       end
     end
 
-    context "when edit is submitted with blank fields" do
-      include_context "Form Submitted with Blank Fields"
-
+    context "when edit is submitted with blank fields", blank_form_submitted: true do
       scenario "comment is not updated" do
         expect(page).not_to have_success_message
         expect(page).to have_failure_message

spec/features/shared/contexts.rb

@@ -1,29 +1,29 @@
 require "rails_helper"
 
 # Pages
-shared_context "Main Page" do
+shared_context "Main Page", page: :main do
   background { visit root_path }
 end
-shared_context "Simple Page" do
+shared_context "Simple Page", page: :simple do
   background { visit simple_path }
 end
-shared_context "Classic Page" do
+shared_context "Classic Page", page: :classic do
   background { visit comments_path }
 end
 
 # Forms
-shared_context "Horizontal Form" do
+shared_context "Horizontal Form", form: :horizontal do
   background { click_link "Horizontal Form" }
 end
-shared_context "Inline Form" do
+shared_context "Inline Form", form: :inline do
   background { click_link "Inline Form" }
 end
-shared_context "Stacked Form" do
+shared_context "Stacked Form", form: :stacked do
   background { click_link "Stacked Form" }
 end
 
 # Form Submission
-shared_context "Form Submitted" do |name: "Spicoli", text: "dude!"|
+shared_context "Form Submitted", form_submitted: true do |name: "Spicoli", text: "dude!"|
   let(:hint_name) { "Your Name" }
   let(:hint_text) { "Say something using markdown..." }
   let(:name) { name }
@@ -36,11 +36,11 @@
   end
 end
 
-shared_context "Form Submitted with Blank Fields" do
+shared_context "Form Submitted with Blank Fields", blank_form_submitted: true do
   include_context "Form Submitted", name: "", text: ""
 end
 
 # Fixtures
-shared_context "Existing Comment" do
+shared_context "Existing Comment", existing_comment: true do
   before { Comment.create(author: "John Doe", text: "Hello there!") }
 end

spec/features/shared/examples.rb

@@ -13,9 +13,8 @@
     end
   end
 
-  context "when the new comment is submmited with blank fields" do
+  context "when the new comment is submmited with blank fields", blank_form_submitted: true do
     let!(:comments_count) { all(".comment").size }
-    include_context "Form Submitted with Blank Fields"
 
     scenario "comment is not added" do
       expect(page).to have_selector(".comment", count: comments_count)