Skip to content

Commit 53882dd

Browse files
committed
Merge pull request shakacode#263 from brucek/update_ruby_and_deps
Update ruby and deps
2 parents df68860 + 9b01eda commit 53882dd

File tree

5 files changed

+12
-10
lines changed

5 files changed

+12
-10
lines changed

.ruby-version

+1-1
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
2.2.4
1+
2.3.0

.travis.yml

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
language:
22
- ruby
33
rvm:
4-
- 2.2.4
4+
- 2.3.0
55
sudo: false
66
addons:
77
apt:

Gemfile

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
source "https://rubygems.org"
2-
ruby "2.2.4"
2+
ruby "2.3.0"
33

44
#
55
# Bundle edge Rails instead: gem "rails", github: "rails/rails"

README.md

+7-6
Original file line numberDiff line numberDiff line change
@@ -68,11 +68,12 @@ See package.json and Gemfile for versions
6868
1. Be sure that you have Node installed! We suggest [nvm](https://github.com/creationix/nvm), with node version `v5.0` or above. See this article [Updating and using nvm](http://forum.shakacode.com/t/updating-and-using-nvm/293).
6969
1. `git clone [email protected]:shakacode/react-webpack-rails-tutorial.git`
7070
1. `cd react-webpack-rails-tutorial`
71-
1. Check that you have Ruby 2.2.4 or greater
71+
1. Check that you have Ruby 2.3.0 or greater
7272
1. Check that you're using the right version of node. Run `nvm list` to check. Use 5.5 or greater.
7373
1. Check that you have Postgres installed. Run `which postgres` to check. Use 9.4 or greater.
7474
1. Check that you have `qmake` installed. Run `which qmake` to check. If missing, follow these instructions: [Installing Qt and compiling capybara-webkit](https://github.com/thoughtbot/capybara-webkit/wiki/Installing-Qt-and-compiling-capybara-webkit)
7575
1. `bundle install`
76+
1. If you get an error installing libv8 on OSX El Capitan, follow these instructions: [Install therubyracer gem on OSX 10.11 El Capitan](http://stackoverflow.com/questions/33475709/install-therubyracer-gem-on-osx-10-11-el-capitan/33475710#33475710)
7677
1. `npm install`
7778
1. `rake db:setup`
7879
1. `foreman start -f Procfile.hot`
@@ -86,7 +87,7 @@ See package.json and Gemfile for versions
8687
2. When you make changes, you have to refresh the browser page.
8788

8889
## Hot Reloading Example: applies to both `Procfile.hot` and `Procfile.express`
89-
1. With the browser open to any JSX file, such as [client/app/bundles/comments/components/CommentBox/CommentBox.jsx](client/app/bundles/comments/components/CommentBox/CommentBox.jsx) and you can change the JSX code, hit save, and you will see the sceen update without refreshing the window. This applies to port 3000 and port 4000.
90+
1. With the browser open to any JSX file, such as [client/app/bundles/comments/components/CommentBox/CommentBox.jsx](client/app/bundles/comments/components/CommentBox/CommentBox.jsx) and you can change the JSX code, hit save, and you will see the screen update without refreshing the window. This applies to port 3000 and port 4000.
9091
1. Try changing a `.scss` file, such as a color in [client/app/bundles/comments/components/CommentBox/CommentList/Comment/Comment.scss](client/app/bundles/comments/components/CommentBox/CommentList/Comment/Comment.scss). You can see port 3000 or 4000 update automatically.
9192
1. Be sure to take a look at the different Procfiles in this directory, as described below.
9293

@@ -171,11 +172,11 @@ bundle exec foreman start -f <Procfile>
171172
1. [`Procfile.dev`](Procfile.dev): Starts the Webpack Dev Server and Rails with Hot Reloading.
172173
2. [`Procfile.hot`](Procfile.hot): Starts the Rails server and the webpack server to provide hot reloading of assets, JavaScript and CSS.
173174
3. [`Procfile.static`](Procfile.static): Starts the Rails server and generates static assets that are used for tests.
174-
4. [`Procfile.express`(Procfile.express): Starts only the Webpack Dev Server.
175-
5. [`Procfile.spec`](Procfile.spec]: Starts webpack to create the static files for tests. **Good to know:** If you want to start `rails s` separately to debug in `pry`, then run `Procfile.spec` to generate the assets and run `rails s` in a separate console.
176-
6. [`Procfile.static.trace`][Procfile.static.trace]: Same as `Procfile.static` but prints tracing information useful for debugging server rendering.
175+
4. [`Procfile.express`](Procfile.express): Starts only the Webpack Dev Server.
176+
5. [`Procfile.spec`](Procfile.spec): Starts webpack to create the static files for tests. **Good to know:** If you want to start `rails s` separately to debug in `pry`, then run `Procfile.spec` to generate the assets and run `rails s` in a separate console.
177+
6. [`Procfile.static.trace`](Procfile.static.trace): Same as `Procfile.static` but prints tracing information useful for debugging server rendering.
177178

178-
In genereral, you want to avoid running more webpack watch processes than you need. The `Procfile.dev`, for example, runs both the express server (Webpack dev server) and the Rails hot assets reloading server.
179+
In general, you want to avoid running more webpack watch processes than you need. The `Procfile.dev`, for example, runs both the express server (Webpack dev server) and the Rails hot assets reloading server.
179180

180181
## Contributors
181182
[The Shaka Code team!](http://www.shakacode.com/about/), led by [Justin Gordon](https://github.com/justin808/), along with with many others. See [contributors.md](docs/contributors.md)

config/initializers/react_on_rails.rb

+2-1
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,8 @@
1010

1111
# Server bundle is a single file for all server rendering of components.
1212
# If you wish to use render_js in your views without any file, set this to "" to avoid warnings.
13-
config.server_bundle_js_file = "app/assets/webpack/server-bundle.js" # This is the default
13+
# Note this is under app/assets/webpack/
14+
config.server_bundle_js_file = "server-bundle.js" # This is the default
1415

1516
# Below options can be overriden by passing to the helper method.
1617
config.prerender = true # default is false

0 commit comments

Comments
 (0)