Use rule identifier as check name

Instead of "net.csslint.Disallow@import" (source, which is a munged
rule.name), just use "import" (rule.id).

Author: pbrisbin

lib/cc/engine/csslint.rb

@@ -20,7 +20,7 @@ def run
               next unless node.name == "error"
 
               lint = node.attributes
-              check_name = lint["source"].value
+              check_name = lint["identifier"].value
               check_details = CheckDetails.fetch(check_name)
 
               issue = {

lib/cc/engine/csslint/check_details.rb

@@ -4,31 +4,31 @@ class CSSlint
       class CheckDetails
         ALL_RULES = {
           # https://github.com/CSSLint/csslint/wiki/Rules
-          "net.csslint.Bewareofbrokenboxsize" => { categories: "Bug Risk" },
-          "net.csslint.Disallow@import" => { categories: "Bug Risk" },
-          "net.csslint.Disallowadjoiningclasses" => { categories: "Compatibility" },
-          "net.csslint.Disallowduplicatebackgroundimages" => { categories: "Bug Risk" },
-          "net.csslint.Disallowduplicateproperties" => { categories: "Bug Risk" },
-          "net.csslint.Disallowemptyrules" => { categories: "Bug Risk" },
-          "net.csslint.Disallownegativetext-indent" => { categories: "Compatibility" },
-          "net.csslint.Disallowoverqualifiedelements" => { categories: "Bug Risk" },
-          "net.csslint.Disallowpropertieswithanunderscoreprefix" => { categories: "Compatibility" },
-          "net.csslint.Disallowpropertieswithastarprefix" => { categories: "Compatibility" },
-          "net.csslint.Disallowselectorsthatlooklikeregexs" => { categories: "Bug Risk" },
-          "net.csslint.Disallowunitsfor0values" => { categories: "Bug Risk" },
-          "net.csslint.Disallowuniversalselector" => { categories: "Bug Risk" },
-          "net.csslint.Disallowunqualifiedattributeselectors" => { categories: "Bug Risk" },
-          "net.csslint.Disallowuseofbox-sizing" => { categories: "Compatibility" },
-          "net.csslint.Don'tusetoomanywebfonts" => { categories: "Bug Risk" },
-          "net.csslint.Headingsshouldonlybedefinedonce" => { categories: "Duplication" },
-          "net.csslint.Requireallgradientdefinitions" => { categories: "Compatibility" },
-          "net.csslint.Requirecompatiblevendorprefixes" => { categories: "Compatibility" },
-          "net.csslint.Requirefallbackcolors" => { categories: "Compatibility" },
-          "net.csslint.Requirepropertiesappropriatefordisplay" => { categories: "Bug Risk" },
-          "net.csslint.Requireshorthandproperties" => { categories: "Bug Risk" },
-          "net.csslint.Requirestandardpropertywithvendorprefix" => { categories: "Compatibility" },
-          "net.csslint.Requireuseofknownproperties" => { categories: "Bug Risk" },
-          "net.csslint.Usethebulletproof@font-facesyntax" => { categories: "Compatibility" },
+          "adjoining-classes" => { categories: "Compatibility" },
+          "box-model" => { categories: "Bug Risk" },
+          "box-sizing" => { categories: "Compatibility" },
+          "bulletproof-font-face" => { categories: "Compatibility" },
+          "compatible-vendor-prefixes" => { categories: "Compatibility" },
+          "display-property-grouping" => { categories: "Bug Risk" },
+          "duplicate-background-images" => { categories: "Bug Risk" },
+          "duplicate-properties" => { categories: "Bug Risk" },
+          "empty-rules" => { categories: "Bug Risk" },
+          "fallback-colors" => { categories: "Compatibility" },
+          "font-faces" => { categories: "Bug Risk" },
+          "gradients" => { categories: "Compatibility" },
+          "import" => { categories: "Bug Risk" },
+          "known-properties" => { categories: "Bug Risk" },
+          "overqualified-elements" => { categories: "Bug Risk" },
+          "regex-selectors" => { categories: "Bug Risk" },
+          "shorthand" => { categories: "Bug Risk" },
+          "star-property-hack" => { categories: "Compatibility" },
+          "text-indent" => { categories: "Compatibility" },
+          "underscore-property-hack" => { categories: "Compatibility" },
+          "unique-headings" => { categories: "Duplication" },
+          "universal-selector" => { categories: "Bug Risk" },
+          "unqualified-attributes" => { categories: "Bug Risk" },
+          "vendor-prefix" => { categories: "Compatibility" },
+          "zero-units" => { categories: "Bug Risk" },
         }.freeze
 
         DEFAULT_CATEGORY = "Style".freeze

spec/cc/engine/csslint/check_details_spec.rb

@@ -4,7 +4,7 @@ class CC::Engine::CSSlint
   describe CheckDetails do
     describe ".fetch" do
       it "returns details for customized checks" do
-        details = CheckDetails.fetch("net.csslint.Disallow@import")
+        details = CheckDetails.fetch("import")
 
         expect(details.categories).to eq ["Bug Risk"]
         expect(details.remediation_points).to eq 50_000