-
Notifications
You must be signed in to change notification settings - Fork 58
Closed
Description
Expected Behavior
npm install browserstack-local
does not produce any warnings, when I install it.
Actual Behavior
$ npm install browserstack-local
npm WARN deprecated formatio@1.1.1: This package is unmaintained. Use @sinonjs/formatio instead
npm WARN deprecated samsam@1.1.2: This package has been deprecated in favour of @sinonjs/samsam
npm WARN deprecated samsam@1.1.3: This package has been deprecated in favour of @sinonjs/samsam
Steps to Reproduce the Problem
npm install browserstack-local
browserstack local arguments
Not relevant.
Platform details
- browserstack-local-nodejs version: latest
- node version: any
- os type and version: any
Details
Warnings come from the sinon
dependency, which is only used in tests, but for some reason listed as a production dependency. There were several PRs (#54, #70, #71) attempting to fix this issue, which all were silently ignored. What is the problem? What needs to be done to get one of them reviewed and merged?
In particular #54 does not do any extra changes, which may be risky, but plainly removes unnecessary dependencies, so consumers don't have to install them and see irrelevant warning.
Activity
fix(test): force newer version of natives to fix failing tests on Nod…
fix(test): force newer version of natives to fix failing tests on Nod…
test:client
silently failing on Travis karma-runner/karma#3343devoto13 commentedon Jul 26, 2019
Fixed by #70