Add tests for version collection

version_collection.go

@@ -9,22 +9,38 @@ import (
 	"strings"
 )
 
+type FileSystemInterface interface {
+	Glob(p string) ([]string, error)
+	ReadFile(f string) ([]byte, error)
+}
+
+type osfs struct{}
+
+func (o osfs) Glob(pattern string) ([]string, error) {
+	return filepath.Glob(pattern)
+}
+
+func (o osfs) ReadFile(file string) ([]byte, error) {
+	return os.ReadFile(file)
+}
+
 type VersionCollection interface {
 	GetVersions() ([]string, error)
 	GetWebAssembly(version string) ([]byte, error)
 }
 
 type fileSystemVersionCollection struct {
+	fs   FileSystemInterface
 	dir  string
 	glob string
 }
 
 func ForFilesystemGlob(dir, glob string) VersionCollection {
-	return &fileSystemVersionCollection{dir, glob}
+	return &fileSystemVersionCollection{osfs{}, dir, glob}
 }
 
 func (f *fileSystemVersionCollection) GetVersions() ([]string, error) {
-	files, err := filepath.Glob(filepath.Join(f.dir, f.glob))
+	files, err := f.fs.Glob(filepath.Join(f.dir, f.glob))
 	if err != nil {
 		return nil, err
 	}
@@ -36,7 +52,7 @@ func (f *fileSystemVersionCollection) GetVersions() ([]string, error) {
 }
 
 func (f *fileSystemVersionCollection) GetWebAssembly(version string) ([]byte, error) {
-	return os.ReadFile(filepath.Join(f.dir, version))
+	return f.fs.ReadFile(filepath.Join(f.dir, version))
 }
 
 type urlVersionCollection struct {

version_collection_test.go

@@ -0,0 +1,74 @@
+package caddy_wasm
+
+import (
+	"net/http"
+	"net/http/httptest"
+	"testing"
+	"testing/fstest"
+)
+
+type testHandler struct {
+	requests []*http.Request
+}
+
+func (t *testHandler) ServeHTTP(res http.ResponseWriter, req *http.Request) {
+	t.requests = append(t.requests, req)
+	res.WriteHeader(200)
+	res.Write([]byte("Ok"))
+}
+
+func TestUrlVersions(t *testing.T) {
+	handler := &testHandler{}
+	server := httptest.NewServer(handler)
+
+	collection := ForURL(server.URL)
+
+	v, e := collection.GetVersions()
+	if e != nil {
+		t.Errorf("Unexpected error: %v", e.Error())
+	}
+	if len(v) != 1 {
+		t.Errorf("Unexpected versions: %v", v)
+	}
+	d, e := collection.GetWebAssembly(v[0])
+	if e != nil {
+		t.Errorf("Unexpected error: %v", e.Error())
+	}
+	if string(d) != "Ok" {
+		t.Errorf("Unexpected data: %v", string(d))
+	}
+}
+
+func TestFileVersions(t *testing.T) {
+	m := fstest.MapFS{}
+	m["some/dir/foo.wasm"] = &fstest.MapFile{Data: []byte("foo")}
+	m["some/dir/bar.wasm"] = &fstest.MapFile{Data: []byte("bar")}
+	f := &fileSystemVersionCollection{
+		m,
+		"some/dir/",
+		"*.wasm",
+	}
+	v, e := f.GetVersions()
+	if e != nil {
+		t.Errorf("Unexpected error: %v", e.Error())
+	}
+	tests := []struct {
+		v string
+		d string
+	}{
+		{"foo.wasm", "foo"},
+		{"bar.wasm", "bar"},
+	}
+	if len(v) != len(tests) {
+		t.Errorf("Unexpected versions: %v", v)
+	}
+	for _, test := range tests {
+		d, e := f.GetWebAssembly(test.v)
+		if e != nil {
+			t.Errorf("Unexpected error: %v", e.Error())
+		}
+		if string(d) != test.d {
+			t.Errorf("Unexpected data: %v", string(d))
+		}
+	}
+}