Skip to content

Save dialog when closing app without changing sketches #1274

Closed
@sstaub

Description

@sstaub

Describe the problem

The save dialog comes up when closing the app even when there are no changes in the sketch.

To reproduce

Open the app, then close immediately without any changes to the sketches.

Expected behavior

The save dialog on closing app should only appear when sketch are edited.

Arduino IDE version

Version: 2.0.0-rc9-nightly-20220802 Date: 2022-08-02T03:47:07.580Z CLI Version: 0.25.1 [436f0bb9] Copyright © 2022 Arduino SA

Operating system

macOS

Operating system version

12.5

Additional context

No response

Issue checklist

  • I searched for previous reports in
    I verified the problem still occurs when using the latest
    My report contains all necessary details

Activity

kittaakos

kittaakos commented on Aug 2, 2022

@kittaakos
Contributor

Related: #1016
Breaking change: 5b486b1#diff-d75767495b70f0c6a10456f6a08ea71728c0b74709a2b697e88b9b50f6890177L65.

The current logic does not check if the document was ever touched.

per1234

per1234 commented on Aug 2, 2022

@per1234
Contributor

Thanks for your report @sstaub. Please confirm whether this issue is specific to new sketches, or whether you also experience it when the unchanged sketch is saved in a normal location on disk.

I can only reproduce the issue with new sketches.

Please note that Arduino IDE 2.x opens example sketches as a sketch, so the issue also occurs with those sketches (as was previously reported at #1026).

self-assigned this
on Aug 2, 2022
sstaub

sstaub commented on Aug 2, 2022

@sstaub
Author

I can confirm that this issue is specific to new sketches. On other saved sketches it works as expected.

InstantMuffin

InstantMuffin commented on Aug 5, 2022

@InstantMuffin
Contributor

Maybe in a way related to #1294?

self-assigned this
on Aug 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

    Development

    Participants

    @kittaakos@sstaub@per1234@InstantMuffin

    Issue actions

      Save dialog when closing app without changing sketches · Issue #1274 · arduino/arduino-ide