Skip to content

Commit 661be98

Browse files
committed
code review fix
1 parent 0ca5cf8 commit 661be98

File tree

2 files changed

+4
-3
lines changed

2 files changed

+4
-3
lines changed

pkg/flasherapi/flasherapi.go

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,6 @@ const R0_IMAGE_VERSION_ID = "20250807-136"
3030
// GetOSImageVersion returns the version of the OS image used in the board.
3131
// It is used by the AppLab to enforce image version compatibility.
3232
func GetOSImageVersion(ctx context.Context, conn remote.RemoteConn) string {
33-
3433
f, err := conn.ReadFile("/etc/buildinfo")
3534
if err != nil {
3635
slog.Warn("Unable to read buildinfo file", "err", err, "using_default", R0_IMAGE_VERSION_ID)

pkg/flasherapi/flasherapi_test.go

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -28,8 +28,10 @@ func TestParseOSImageVersion(t *testing.T) {
2828
found bool
2929
}{
3030
{
31-
name: "valid build id",
32-
input: "BUILD_ID=\"20251006-395\"\nVARIANT_ID=xfce",
31+
name: "valid build id",
32+
input: `BUILD_ID="20251006-395"
33+
VARIANT_ID=xfce"
34+
`,
3335
expected: "20251006-395",
3436
found: true,
3537
},

0 commit comments

Comments
 (0)