Address review.

Author: martacarbone

debian/arduino-app-cli/DEBIAN/helper_func.sh

@@ -13,8 +13,6 @@ cleanup_arduino_examples() {
         local EXAMPLES=$(find "${EXAMPLES_DIR}" -maxdepth 1 -mindepth 1 -type d 2>/dev/null)
         echo "Stopping apps and clearing cache in: ${EXAMPLES_DIR}"
         for dir_path in ${EXAMPLES}; do
-            echo "  -> Stopping app/removing cache in: ${dir_path}"
-            
             # 1. Stop the application (suppress output and errors)
             sudo -u arduino /usr/bin/arduino-app-cli app stop "${dir_path}" > /dev/null 2>&1 || true
 

debian/arduino-app-cli/DEBIAN/postinst

@@ -5,3 +5,10 @@ chown -R arduino:arduino /var/lib/arduino-app-cli
 systemctl enable arduino-app-cli
 systemctl enable arduino-burn-bootloader
 systemctl enable arduino-avahi-serial.service
+
+if [ "$1" = "configure" ]; then
+  if dpkg --compare-versions "$2" lt "0.9.0"; then
+    echo "Running pre-0.9.0 legacy migration..."
+    rm -rf /home/arduino/.local/share/arduino-app-cli/examples
+  fi
+fi

debian/arduino-app-cli/DEBIAN/preinst

@@ -28,12 +28,11 @@ usermod -aG "$SYSUPGRADE_GROUP" "$APP_USER"
 # SHARED_FUNCTIONS
 
 if [ "$1" = "upgrade" ]; then
-  # if $2 is not empty, this is an upgrade
-  if [ -n "$2" ]; then
-    # check if this is an upgrade from an old version
-    if dpkg --compare-versions "$2" lt "0.9.0"; then
-        echo "Running pre-0.9.0 legacy cleanup/migration..."
-        cleanup_arduino_examples /home/arduino/.local/share/arduino-app-cli/examples
-    fi
+  # check if this is an upgrade from an old version
+  if dpkg --compare-versions "$2" lt "0.9.0"; then
+    echo "Running pre-0.9.0 legacy migration..."
+    cleanup_arduino_examples /home/arduino/.local/share/arduino-app-cli/examples
+    mkdir -p /var/lib/arduino-app-cli
+    cp -rf /home/arduino/.local/share/arduino-app-cli/examples /var/lib/arduino-app-cli
   fi
 fi

debian/arduino-app-cli/DEBIAN/prerm

@@ -1,13 +1,12 @@
 #!/bin/sh
 
 set -e
+
 systemctl disable arduino-app-cli
 systemctl disable arduino-burn-bootloader
 systemctl disable arduino-avahi-serial.service
 
 # SHARED_FUNCTIONS
 
-echo "Running pre-0.8.0 legacy cleanup/migration..."
-cleanup_arduino_examples /home/arduino/.local/share/arduino-app-cli/examples
 echo "Cache cleanup..."
 cleanup_arduino_examples /var/lib/arduino-app-cli/examples