Merge branch 'issue_41_flasher_api' into issue_44_flasher_api

Author: martacarbone

pkg/flasherapi/flasherapi.go

@@ -17,7 +17,6 @@ package flasherapi
 
 import (
 	"bufio"
-	"context"
 	"io"
 	"log/slog"
 	"strings"
@@ -29,8 +28,7 @@ const R0_IMAGE_VERSION_ID = "20250807-136"
 
 // GetOSImageVersion returns the version of the OS image used in the board.
 // It is used by the AppLab to enforce image version compatibility.
-func GetOSImageVersion(ctx context.Context, conn remote.RemoteConn) string {
-
+func GetOSImageVersion(conn remote.RemoteConn) string {
 	f, err := conn.ReadFile("/etc/buildinfo")
 	if err != nil {
 		slog.Warn("Unable to read buildinfo file", "err", err, "using_default", R0_IMAGE_VERSION_ID)

pkg/flasherapi/flasherapi_test.go

@@ -12,14 +12,62 @@
 // modify or otherwise use the software for commercial activities involving the
 // Arduino software without disclosing the source code of your own applications.
 // To purchase a commercial license, send an email to [email protected].
-
 package flasherapi
 
 import (
+	"context"
+	"io"
 	"strings"
 	"testing"
+
+	"github.com/stretchr/testify/require"
+
+	"github.com/arduino/arduino-app-cli/pkg/board/remote"
 )
 
+// implements remote.RemoteConn
+type MockRemoteConn struct {
+	ReadFileFunc func(path string) (io.ReadCloser, error)
+}
+
+func (m *MockRemoteConn) ReadFile(path string) (io.ReadCloser, error) {
+	return m.ReadFileFunc(path)
+}
+
+// Empty definitions
+func (m *MockRemoteConn) List(path string) ([]remote.FileInfo, error) {
+	return nil, nil
+}
+func (m *MockRemoteConn) MkDirAll(path string) error {
+	return nil
+}
+func (m *MockRemoteConn) Remove(path string) error {
+	return nil
+}
+func (m *MockRemoteConn) Stats(path string) (remote.FileInfo, error) {
+	return remote.FileInfo{}, nil
+}
+func (m *MockRemoteConn) WriteFile(data io.Reader, path string) error {
+	return nil
+}
+func (m *MockRemoteConn) GetCmd(cmd string, args ...string) remote.Cmder {
+	return nil
+}
+func (m *MockRemoteConn) Forward(ctx context.Context, localPort int, remotePort int) error {
+	return nil
+}
+func (m *MockRemoteConn) ForwardKillAll(ctx context.Context) error {
+	return nil
+}
+func createBuildInfoConnection(imageVersion string) remote.RemoteConn {
+	mockConn := MockRemoteConn{
+		ReadFileFunc: func(path string) (io.ReadCloser, error) {
+			return io.NopCloser(strings.NewReader(imageVersion)), nil
+		},
+	}
+	return &mockConn
+}
+
 func TestParseOSImageVersion(t *testing.T) {
 	tests := []struct {
 		name     string
@@ -44,7 +92,6 @@ func TestParseOSImageVersion(t *testing.T) {
 			found: false,
 		},
 	}
-
 	for _, tt := range tests {
 		t.Run(tt.name, func(t *testing.T) {
 			got, ok := parseOSImageVersion(strings.NewReader(tt.input))
@@ -54,3 +101,11 @@ func TestParseOSImageVersion(t *testing.T) {
 		})
 	}
 }
+
+func TestGetOSImageVersion(t *testing.T) {
+	const R0_IMAGE_VERSION_ID = "20250807-136"
+	R0Version := createBuildInfoConnection(R0_IMAGE_VERSION_ID)
+	AnotherVersion := createBuildInfoConnection("BUILD_ID=20250101-001")
+	require.Equal(t, GetOSImageVersion(R0Version), R0_IMAGE_VERSION_ID)
+	require.Equal(t, GetOSImageVersion(AnotherVersion), "20250101-001")
+}