Conflicting methods `min` and `max` on `Set` and `Map`

[KodrAus]

In rust-lang/rust#42496, methods min and max were added to the Ord trait.

These methods are shadowing the inherent min and max on Set and Map (see: rust-lang/rust#43682), and unfortunately don't have the same signature, and there doesn't seem to be a single obvious fix for tree.

The easiest thing to do is rename Map.min/max and Set.min/max or just remove those methods. It might also be possible to design around the issue by exposing the min and max functions on a type that doesn't implement Ord. Maybe something like Map.find().min() and Map.find_mut().min()?

[KodrAus]

cc: @apasel422

[apasel422]

I'd accept a pull request that renames the min methods to first and the max methods to last.

[KodrAus]

Would you want to keep the naming consistent for remove_min, min_entry etc? So remove_first, first_entry?

[apasel422]

Those should be changed as well.

[KodrAus]

No worries, I'll submit a PR shortly 👍