-
Notifications
You must be signed in to change notification settings - Fork 3k
Closed
Labels
good first issueGood for newcomersGood for newcomersimprovementPR that improves existing functionalityPR that improves existing functionality
Description
Feature Request / Improvement
In a bunch of places around the codebase we typically test Java & Kryo serialization as following
@Test
public void testResolvingFileIOKryoSerialization() throws IOException {
FileIO testResolvingFileIO = new ResolvingFileIO();
// resolving fileIO should be serializable when properties are passed as immutable map
testResolvingFileIO.initialize(ImmutableMap.of("k1", "v1"));
FileIO roundTripSerializedFileIO =
TestHelpers.KryoHelpers.roundTripSerialize(testResolvingFileIO);
assertThat(roundTripSerializedFileIO.properties()).isEqualTo(testResolvingFileIO.properties());
}
@Test
public void testResolvingFileIOJavaSerialization() throws IOException, ClassNotFoundException {
FileIO testResolvingFileIO = new ResolvingFileIO();
// resolving fileIO should be serializable when properties are passed as immutable map
testResolvingFileIO.initialize(ImmutableMap.of("k1", "v1"));
FileIO roundTripSerializedFileIO = TestHelpers.roundTripSerialize(testResolvingFileIO);
assertThat(roundTripSerializedFileIO.properties()).isEqualTo(testResolvingFileIO.properties());
}
The main difference in those tests is calling TestHelpers.roundTripSerialize vs TestHelpers.KryoHelpers.roundTripSerialize.
It would be good to unify those tests and make the type of serialization a test parameter
Query engine
None
Willingness to contribute
- I can contribute this improvement/feature independently
- I would be willing to contribute this improvement/feature with guidance from the Iceberg community
- I cannot contribute this improvement/feature at this time
Metadata
Metadata
Assignees
Labels
good first issueGood for newcomersGood for newcomersimprovementPR that improves existing functionalityPR that improves existing functionality