fix(parquet/pqarrow): selective column reading of complex map column#668
Merged
zeroshade merged 3 commits intoapache:mainfrom Feb 20, 2026
Merged
fix(parquet/pqarrow): selective column reading of complex map column#668zeroshade merged 3 commits intoapache:mainfrom
zeroshade merged 3 commits intoapache:mainfrom
Conversation
|
Thanks for fixing this quickly, @zeroshade! This is very much appreciated. |
lidavidm
approved these changes
Feb 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
Upstream fix for the issue identified in apache/iceberg-go#737. When reading maps with nested values using column indices for selective column reading, if the child fields of the map weren't in the list of indices there was a problem:
list<struct<key, value>>Map.validateData()method would fail with a panic ofarrow/array: map array child array should have two fields.What changes are included in this PR?
In pqarrow/file_reader.go leaf filtering is disabled when reading a map's key-value struct. This will ensure both the key and value columns are always read together, maintaining the required 2-field structure for map array.
Are these changes tested?
Yes a test case is added for the change.
Are there any user-facing changes?
This only affects map type reading with column filter selection ensuring correctness. The only change is that a failure mode has been eliminated.