Skip to content

Closure compiling renames external resources methods #3588

@mkhatib

Description

@mkhatib

Reproduce:

  • Build a local master with gulp build --fortesting && gulp dist --fortesting
  • Run gulp
  • Navigate to ads.amp.min.html example in the browser
  • Scroll toward Criteo ad
  • Notice the following error in the console.
criteo.js:25 - Uncaught TypeError: Criteo.l is not a function

This points to this code. Closure compiler seems to be renaming Criteo.DisplayAd to Criteo.l. Similar errors might be happening elsewhere.

Metadata

Metadata

Assignees

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions