You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR creates a new browser. spec to add examples to the index page of interactions, and move all the examples out of the docs into their correspondents specs
Motivation and Context
The examples and documentation must be easy to maintain, so migrating static code into examples will help this goal
Types of changes
Change to the site (I have double-checked the Netlify deployment, and my changes look good)
Code example added (and I also added the example to all translated languages)
Improved translation
Added new translation (and I also added a notice to each document missing translation)
Why: Using a variable for the URL reduces repetition and makes the code easier to maintain and update. This is a good practice for improving code readability and maintainability.
8
Enhancement
Add page title checks to navigation tests for better validation
Add assertions to check the page title in addition to the URL to ensure that the navigation is successful and the expected page is loaded.
Why: Adding page title checks provides better validation that the correct page has loaded, enhancing the robustness of the tests. However, the expected title should be accurate and meaningful.
7
Maintainability
Improve the formatting of the Ruby code block within the tab structure
Ensure that the Ruby code block is correctly formatted and enclosed within the tab structure for consistency with other language tabs.
Why: The suggestion improves the readability and maintainability of the document by ensuring consistent indentation, but it is a minor formatting change.
5
Adjust indentation for consistency and improved readability in the Ruby section
Ensure consistent indentation within the tab structure for the Ruby example to improve the document's structure and readability.
Why: While combining the navigation and URL check into a single step might reduce redundancy, it can make the test harder to read and debug. The current approach is clearer.
2
Readability
Add a newline for better readability in the Ruby tab section
Add a newline after the Ruby tab header for better readability and consistency with other sections.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
User description
Description
This PR creates a new browser. spec to add examples to the index page of interactions, and move all the examples out of the docs into their correspondents specs
Motivation and Context
The examples and documentation must be easy to maintain, so migrating static code into examples will help this goal
Types of changes
Checklist
PR Type
Documentation, Tests
Description
Changes walkthrough 📝
2 files
browser_spec.rb
Add RSpec tests for browser interactions
examples/ruby/spec/interactions/browser_spec.rb
navigation_spec.rb
Add RSpec tests for navigation interactions
examples/ruby/spec/interactions/navigation_spec.rb
8 files
_index.en.md
Update Ruby examples for title and URL interactions
website_and_docs/content/documentation/webdriver/interactions/_index.en.md
_index.ja.md
Update Ruby examples for title and URL interactions (Japanese)
website_and_docs/content/documentation/webdriver/interactions/_index.ja.md
_index.pt-br.md
Update Ruby examples for title and URL interactions (Portuguese)
website_and_docs/content/documentation/webdriver/interactions/_index.pt-br.md
_index.zh-cn.md
Update Ruby examples for title and URL interactions (Chinese)
website_and_docs/content/documentation/webdriver/interactions/_index.zh-cn.md
navigation.en.md
Update Ruby examples for navigation interactions
website_and_docs/content/documentation/webdriver/interactions/navigation.en.md
navigation.ja.md
Update Ruby examples for navigation interactions (Japanese)
website_and_docs/content/documentation/webdriver/interactions/navigation.ja.md
navigation.pt-br.md
Update Ruby examples for navigation interactions (Portuguese)
website_and_docs/content/documentation/webdriver/interactions/navigation.pt-br.md
navigation.zh-cn.md
Update Ruby examples for navigation interactions (Chinese)
website_and_docs/content/documentation/webdriver/interactions/navigation.zh-cn.md