[BUILD] Fix libthrift vulnerabilities. #42
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhangbinzaifendou
pushed a commit
to zhangbinzaifendou/XSQL
that referenced
this pull request
Sep 20, 2019
What changes were proposed in this pull request? The current code uses org.apache.thrift:libthrift:jar:0.9.3 and it will cause a security vulnerabilities. We received some alerts like https://github.com/Qihoo360/XSQL/network/alert/pom.xml/org.apache.thrift:libthrift/open This Alert remind to upgrate the version of libthrift to 0.12.0 or later. I referenced Spark 3.0.0 contains libthrift:jar:0.12.0 too. The pom.xml contains the variable libthrift.version which is used by libthrift and libfb303. If upgrade libthrift.version to 0.12.0 will lead to an issue libfb303:jar:0.12.0 can't be find. So this PR retain libfb303 with version 0.9.3 and upgrade libthrift to 0.12.0.
zhangbinzaifendou
pushed a commit
to zhangbinzaifendou/XSQL
that referenced
this pull request
Sep 20, 2019
What changes were proposed in this pull request? The current code uses org.apache.thrift:libthrift:jar:0.9.3 and it will cause a security vulnerabilities. We received some alerts like https://github.com/Qihoo360/XSQL/network/alert/pom.xml/org.apache.thrift:libthrift/open This Alert remind to upgrate the version of libthrift to 0.12.0 or later. I referenced Spark 3.0.0 contains libthrift:jar:0.12.0 too. The pom.xml contains the variable libthrift.version which is used by libthrift and libfb303. If upgrade libthrift.version to 0.12.0 will lead to an issue libfb303:jar:0.12.0 can't be find. So this PR retain libfb303 with version 0.9.3 and upgrade libthrift to 0.12.0.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
The current code uses
org.apache.thrift:libthrift:jar:0.9.3and it will cause a security vulnerabilities. We received some alerts like https://github.com/Qihoo360/XSQL/network/alert/pom.xml/org.apache.thrift:libthrift/openThis Alert remind to upgrate the version of libthrift to 0.12.0 or later.
I referenced Spark 3.0.0 contains
libthrift:jar:0.12.0too.The pom.xml contains the variable
libthrift.versionwhich is used bylibthriftandlibfb303. If upgradelibthrift.versionto 0.12.0 will lead to an issuelibfb303:jar:0.12.0can't be find.So this PR retain
libfb303with version 0.9.3 and upgradelibthriftto 0.12.0.