feat: Add 'show solution' in editor context menu & code lens #313
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Vigilans
approved these changes
May 9, 2019
| return; | ||
| } | ||
|
|
||
| const language: string | undefined = await fetchProblemLanguage(); |
There was a problem hiding this comment.
We could utilize file extension (path.extName()) and shared.ts/langExt to determine the language, thus no need for re-selecting the language when showing solution from the code:
export const langExt: Map<string, string> = new Map([
["bash", "sh"],
["c", "c"],
["cpp", "cpp"],
["csharp", "cs"],
["golang", "go"],
["java", "java"],
["javascript", "js"],
["kotlin", "kt"],
["mysql", "sql"],
["php", "php"],
["python", "py"],
["python3", "py"],
["ruby", "rb"],
["rust", "rs"],
["scala", "scala"],
["swift", "swift"],
]);(Yet this choice comes with a risk: currently showing solution for languages like scala has a high probability to fail. This feature could be added in later PR when logic of solution plugin is improved.)
There was a problem hiding this comment.
another rick is that it's hard to differentiate py3 & py2 from the extName
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolve #269
Need to release cli first.