Skip to content

Signed out after switching endpoint, even if it's the same endpoint. #129

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
kevjin opened this issue Feb 17, 2019 · 1 comment · Fixed by #337
Closed

Signed out after switching endpoint, even if it's the same endpoint. #129

kevjin opened this issue Feb 17, 2019 · 1 comment · Fixed by #337
Labels
bug Something isn't working
Milestone

Comments

@kevjin
Copy link

kevjin commented Feb 17, 2019

What happens
If I am initially signed into leetcode.com (US Endpoint) and I decide to click "Switch Endpoint" and I choose the US Endpoint, the app will sign me out of my leetcode account anyway.

What should happen
If I am already signed into an endpoint and I choose the same endpoint again from the Switch Endpoint button, either A. nothing should happen, or B. a notification that says "You are already signed in. Use the Sign Out command to sign out" appears.

This is a very small issue pertaining to UX. It's not something a user would expect would happen and it doesn't make much sense for users to sign out by relying on the switch endpoint button. It would be nice to have this fixed, and I can make a PR for it as well. Thanks!

@jdneo
Copy link
Member

jdneo commented Feb 17, 2019

@kevjin Thank you for reporting this issue. It will be great if you would like to send out a PR for this. Give it a shoot!

@jdneo jdneo added the bug Something isn't working label Feb 17, 2019
@jdneo jdneo added this to the 0.14.4 milestone Jun 1, 2019
@jdneo jdneo closed this as completed in #337 Jun 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants