Skip to content

Conversation

@sloede
Copy link
Contributor

@sloede sloede commented Sep 5, 2023

This PR enables users to manually specify a tag prefix, overriding the default tag prefix determination algorithm (the DTPDA, as it will henceforth be referred to as).

Before:

  • subdir="": tag prefix is v, e.g., v0.1.0
  • subdir="foo": tag prefix is foo-v, e.g., foo-v0.1.0

With this PR, there are additional options available through the tag_prefix input:

  • tag_prefix="" (default): as before
  • tag_prefix="bar": tag prefix is bar-v, e.g., bar-v0.1.0 (whatever the content of subdir)
  • tag_prefix="NO_PREFIX": tag prefix is v, e.g., v0.1.0 (whatever the content of subdir)

The main motivation is to allow users who have their Julia package in a subdirectory but want to tag their versions just as v0.1.0 and not as subdir-v0.1.0 to use TagBot (which is an awesome action, thanks a lot to all maintainers!). This should be a non-breaking change, since the DTPDA remains unchanged if the new action input tag_prefix is not set.

Resolves #278.

cc @bgeihe

@sloede
Copy link
Contributor Author

sloede commented Sep 11, 2023

bump Who would be the right person to do a (first) review for this PR - @christopher-dG?

@christopher-dG
Copy link
Member

Looks good at a glance, but would be good to get review from @IanButterworth

@IanButterworth IanButterworth merged commit 7a82a9f into JuliaRegistries:master Sep 11, 2023
@sloede sloede deleted the msl/configure-tag-prefix branch September 11, 2023 17:18
@sloede
Copy link
Contributor Author

sloede commented Sep 11, 2023

Thanks for the merge @IanButterworth! It would be great if you could also create a new tag (I don't think I can do this as a PR, or can I?), such that it is usable in our workflows.

@IanButterworth
Copy link
Member

Yeah. I've messaged @christopher-dG because there's more to it than a PR AFAIK but I don't know what that is

@sloede
Copy link
Contributor Author

sloede commented Sep 11, 2023

OK, great, thanks a lot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Modify TagBot tag prefix for subdir packages

3 participants