Skip to content

Conversation

@XivLaw
Copy link
Contributor

@XivLaw XivLaw commented Apr 15, 2022

Please make sure these boxes are checked before submitting your PR, thank you!

  • Make sure you follow Element's contributing guide (中文 | English | Español | Français).
  • Make sure you are merging your commits to dev branch.
  • Add some descriptions and refer relative issues for you PR.

Fix: #21802
fix the dropdown animation direction of cascader and datepicker

before
GIF 2022-4-16 0-08-36

fixed
GIF 2022-4-16 0-37-55

@xinguanhua xinguanhua merged commit 807e208 into ElemeFE:dev Jun 2, 2022
@lqzhgood
Copy link
Contributor

lqzhgood commented Jun 6, 2022

升级以后报错了,应该是直接修改了 props placement

[Vue warn]: Avoid mutating a prop directly since the value will be overwritten whenever the parent component re-renders. Instead, use a data or computed property based on the prop's value. Prop being mutated: "placement"

found in

---> <ElDatePicker> at packages/date-picker/src/picker.vue

@yangbuyiya
Copy link

尼玛的乱搞是吧

hzsrc pushed a commit to hzsrc/element that referenced this pull request Feb 2, 2023
hzsrc pushed a commit to hzsrc/element that referenced this pull request Feb 2, 2023
this PR ElemeFE#21806 erroneously changed "placement" `data` -> `props`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug Report] DatePicker/DateTimePicker 处于页面底部时,下拉菜单展开显示的动画方向不正确

4 participants