Error Logs Remediation by ygree · Pull Request #9459 · DataDog/dd-trace-java

ygree · 2025-09-03T17:32:37Z

What Does This Do

Prevents passing exception messages and dynamically concatenated strings as an error message to the telemetry

Motivation

Sensitive data leaks prevention

Additional Notes

Contributor Checklist

Format the title according the contribution guidelines
Assign the type: and (comp: or inst:) labels in addition to any usefull labels
Don't use close, fix or any linking keywords when referencing an issue.
Use solves instead, and assign the PR milestone to the issue
Update the CODEOWNERS file on source file addition, move, or deletion
Update the public documentation in case of new configuration flag or behavior

Jira ticket: [PROJ-IDENT]

github-actions · 2025-09-03T17:32:48Z

Hi! 👋 Thanks for your pull request! 🎉

To help us review it, please make sure to:

Add at least one type, and one component or instrumentation label to the pull request

If you need help, please check our contributing guidelines.

datadog-datadog-prod-us1 · 2025-09-03T17:53:55Z

🎯 Code Coverage
• Patch Coverage: 100.00%
• Total Coverage: 57.65% (+0.01%)

View detailed report

_{This comment will be updated automatically if new data arrives.

🔗 Commit SHA: 658120f | Docs | Was this helpful? Give us feedback!}

pr-commenter · 2025-09-03T18:03:56Z

Benchmarks

Startup

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
git_branch	master	ygree/error-logs-remediation
git_commit_date	1756932532	1756938857
git_commit_sha	`91f4636`	`658120f`
release_version	1.53.0-SNAPSHOT~91f463686c	1.53.0-SNAPSHOT~658120f76e

See matching parameters

	Baseline	Candidate
application	insecure-bank	insecure-bank
ci_job_date	1756940635	1756940635
ci_job_id	1112552117	1112552117
ci_pipeline_id	75489894	75489894
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version	Linux runner-zfyrx7zua-project-304-concurrent-0-tapvkmki 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux	Linux runner-zfyrx7zua-project-304-concurrent-0-tapvkmki 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
module	Agent	Agent
parent	None	None

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 43 metrics, 16 unstable metrics.

Startup time reports for petclinic

gantt
    title petclinic - global startup overhead: candidate=1.53.0-SNAPSHOT~658120f76e, baseline=1.53.0-SNAPSHOT~91f463686c

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.049 s) : 0, 1049090
Total [baseline] (10.641 s) : 0, 10641356
Agent [candidate] (1.05 s) : 0, 1049624
Total [candidate] (10.696 s) : 0, 10695882
section appsec
Agent [baseline] (1.223 s) : 0, 1222818
Total [baseline] (10.782 s) : 0, 10781837
Agent [candidate] (1.233 s) : 0, 1232587
Total [candidate] (10.828 s) : 0, 10828176
section iast
Agent [baseline] (1.188 s) : 0, 1188383
Total [baseline] (11.09 s) : 0, 11089593
Agent [candidate] (1.184 s) : 0, 1183548
Total [candidate] (11.032 s) : 0, 11032171
section profiling
Agent [baseline] (1.199 s) : 0, 1198921
Total [baseline] (10.892 s) : 0, 10891528
Agent [candidate] (1.201 s) : 0, 1200748
Total [candidate] (10.875 s) : 0, 10874882

baseline results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.049 s	-
Agent	appsec	1.223 s	173.728 ms (16.6%)
Agent	iast	1.188 s	139.293 ms (13.3%)
Agent	profiling	1.199 s	149.831 ms (14.3%)
Total	tracing	10.641 s	-
Total	appsec	10.782 s	140.481 ms (1.3%)
Total	iast	11.09 s	448.238 ms (4.2%)
Total	profiling	10.892 s	250.173 ms (2.4%)

candidate results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.05 s	-
Agent	appsec	1.233 s	182.963 ms (17.4%)
Agent	iast	1.184 s	133.925 ms (12.8%)
Agent	profiling	1.201 s	151.124 ms (14.4%)
Total	tracing	10.696 s	-
Total	appsec	10.828 s	132.294 ms (1.2%)
Total	iast	11.032 s	336.289 ms (3.1%)
Total	profiling	10.875 s	179.0 ms (1.7%)

gantt
    title petclinic - break down per module: candidate=1.53.0-SNAPSHOT~658120f76e, baseline=1.53.0-SNAPSHOT~91f463686c

    dateFormat X
    axisFormat %s
section tracing
crashtracking [baseline] (1.466 ms) : 0, 1466
crashtracking [candidate] (1.442 ms) : 0, 1442
BytebuddyAgent [baseline] (733.575 ms) : 0, 733575
BytebuddyAgent [candidate] (733.747 ms) : 0, 733747
GlobalTracer [baseline] (242.265 ms) : 0, 242265
GlobalTracer [candidate] (243.457 ms) : 0, 243457
AppSec [baseline] (30.094 ms) : 0, 30094
AppSec [candidate] (30.177 ms) : 0, 30177
Debugger [baseline] (6.019 ms) : 0, 6019
Debugger [candidate] (6.08 ms) : 0, 6080
Remote Config [baseline] (687.92 µs) : 0, 688
Remote Config [candidate] (669.865 µs) : 0, 670
Telemetry [baseline] (13.816 ms) : 0, 13816
Telemetry [candidate] (12.924 ms) : 0, 12924
section appsec
crashtracking [baseline] (1.456 ms) : 0, 1456
crashtracking [candidate] (1.451 ms) : 0, 1451
BytebuddyAgent [baseline] (755.996 ms) : 0, 755996
BytebuddyAgent [candidate] (761.615 ms) : 0, 761615
GlobalTracer [baseline] (235.302 ms) : 0, 235302
GlobalTracer [candidate] (237.118 ms) : 0, 237118
AppSec [baseline] (170.508 ms) : 0, 170508
AppSec [candidate] (168.624 ms) : 0, 168624
Debugger [baseline] (5.778 ms) : 0, 5778
Debugger [candidate] (6.661 ms) : 0, 6661
Remote Config [baseline] (636.889 µs) : 0, 637
Remote Config [candidate] (654.894 µs) : 0, 655
Telemetry [baseline] (8.47 ms) : 0, 8470
Telemetry [candidate] (11.562 ms) : 0, 11562
IAST [baseline] (23.499 ms) : 0, 23499
IAST [candidate] (23.743 ms) : 0, 23743
section iast
crashtracking [baseline] (1.467 ms) : 0, 1467
crashtracking [candidate] (1.446 ms) : 0, 1446
BytebuddyAgent [baseline] (858.296 ms) : 0, 858296
BytebuddyAgent [candidate] (852.836 ms) : 0, 852836
GlobalTracer [baseline] (234.242 ms) : 0, 234242
GlobalTracer [candidate] (235.133 ms) : 0, 235133
AppSec [baseline] (26.394 ms) : 0, 26394
AppSec [candidate] (28.677 ms) : 0, 28677
Debugger [baseline] (7.525 ms) : 0, 7525
Debugger [candidate] (5.751 ms) : 0, 5751
Remote Config [baseline] (628.238 µs) : 0, 628
Remote Config [candidate] (601.491 µs) : 0, 601
Telemetry [baseline] (8.38 ms) : 0, 8380
Telemetry [candidate] (8.426 ms) : 0, 8426
IAST [baseline] (30.298 ms) : 0, 30298
IAST [candidate] (29.601 ms) : 0, 29601
section profiling
crashtracking [baseline] (1.429 ms) : 0, 1429
crashtracking [candidate] (1.436 ms) : 0, 1436
BytebuddyAgent [baseline] (763.047 ms) : 0, 763047
BytebuddyAgent [candidate] (764.748 ms) : 0, 764748
GlobalTracer [baseline] (223.227 ms) : 0, 223227
GlobalTracer [candidate] (223.546 ms) : 0, 223546
AppSec [baseline] (30.028 ms) : 0, 30028
AppSec [candidate] (30.025 ms) : 0, 30025
Debugger [baseline] (6.291 ms) : 0, 6291
Debugger [candidate] (7.016 ms) : 0, 7016
Remote Config [baseline] (728.025 µs) : 0, 728
Remote Config [candidate] (685.561 µs) : 0, 686
Telemetry [baseline] (16.535 ms) : 0, 16535
Telemetry [candidate] (15.574 ms) : 0, 15574
ProfilingAgent [baseline] (107.246 ms) : 0, 107246
ProfilingAgent [candidate] (107.291 ms) : 0, 107291
Profiling [baseline] (107.911 ms) : 0, 107911
Profiling [candidate] (107.958 ms) : 0, 107958

Startup time reports for insecure-bank

gantt
    title insecure-bank - global startup overhead: candidate=1.53.0-SNAPSHOT~658120f76e, baseline=1.53.0-SNAPSHOT~91f463686c

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.048 s) : 0, 1048123
Total [baseline] (8.644 s) : 0, 8643764
Agent [candidate] (1.05 s) : 0, 1050330
Total [candidate] (8.634 s) : 0, 8634071
section iast
Agent [baseline] (1.182 s) : 0, 1182134
Total [baseline] (9.348 s) : 0, 9348095
Agent [candidate] (1.198 s) : 0, 1197747
Total [candidate] (9.322 s) : 0, 9322214

baseline results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.048 s	-
Agent	iast	1.182 s	134.011 ms (12.8%)
Total	tracing	8.644 s	-
Total	iast	9.348 s	704.331 ms (8.1%)

candidate results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.05 s	-
Agent	iast	1.198 s	147.417 ms (14.0%)
Total	tracing	8.634 s	-
Total	iast	9.322 s	688.143 ms (8.0%)

gantt
    title insecure-bank - break down per module: candidate=1.53.0-SNAPSHOT~658120f76e, baseline=1.53.0-SNAPSHOT~91f463686c

    dateFormat X
    axisFormat %s
section tracing
crashtracking [baseline] (1.448 ms) : 0, 1448
crashtracking [candidate] (1.475 ms) : 0, 1475
BytebuddyAgent [baseline] (733.197 ms) : 0, 733197
BytebuddyAgent [candidate] (737.402 ms) : 0, 737402
GlobalTracer [baseline] (242.211 ms) : 0, 242211
GlobalTracer [candidate] (242.992 ms) : 0, 242992
AppSec [baseline] (30.06 ms) : 0, 30060
AppSec [candidate] (30.013 ms) : 0, 30013
Debugger [baseline] (6.039 ms) : 0, 6039
Debugger [candidate] (6.037 ms) : 0, 6037
Remote Config [baseline] (671.076 µs) : 0, 671
Remote Config [candidate] (672.429 µs) : 0, 672
Telemetry [baseline] (13.575 ms) : 0, 13575
Telemetry [candidate] (10.615 ms) : 0, 10615
section iast
crashtracking [baseline] (1.461 ms) : 0, 1461
crashtracking [candidate] (1.464 ms) : 0, 1464
BytebuddyAgent [baseline] (852.799 ms) : 0, 852799
BytebuddyAgent [candidate] (866.07 ms) : 0, 866070
GlobalTracer [baseline] (234.596 ms) : 0, 234596
GlobalTracer [candidate] (235.586 ms) : 0, 235586
AppSec [baseline] (27.159 ms) : 0, 27159
AppSec [candidate] (27.115 ms) : 0, 27115
Debugger [baseline] (6.594 ms) : 0, 6594
Debugger [candidate] (7.437 ms) : 0, 7437
Remote Config [baseline] (608.378 µs) : 0, 608
Remote Config [candidate] (601.986 µs) : 0, 602
Telemetry [baseline] (8.269 ms) : 0, 8269
Telemetry [candidate] (9.182 ms) : 0, 9182
IAST [baseline] (29.611 ms) : 0, 29611
IAST [candidate] (29.003 ms) : 0, 29003

Load

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
git_branch	master	ygree/error-logs-remediation
git_commit_date	1756932532	1756938857
git_commit_sha	`91f4636`	`658120f`
release_version	1.53.0-SNAPSHOT~91f463686c	1.53.0-SNAPSHOT~658120f76e

See matching parameters

	Baseline	Candidate
application	insecure-bank	insecure-bank
ci_job_date	1756940296	1756940296
ci_job_id	1112552118	1112552118
ci_pipeline_id	75489894	75489894
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version	Linux runner-zfyrx7zua-project-304-concurrent-1-rsz7on40 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux	Linux runner-zfyrx7zua-project-304-concurrent-1-rsz7on40 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux

Summary

Found 2 performance improvements and 3 performance regressions! Performance is the same for 7 metrics, 12 unstable metrics.

scenario	Δ mean http_req_duration	Δ mean throughput	candidate mean http_req_duration	candidate mean throughput	baseline mean http_req_duration	baseline mean throughput
scenario:load:insecure-bank:iast_GLOBAL:high_load	worse [+259.186µs; +653.525µs] or [+2.558%; +6.449%]	unstable [-74.102op/s; +35.102op/s] or [-16.164%; +7.657%]	10.590ms	438.938op/s	10.134ms	458.438op/s
scenario:load:petclinic:tracing:high_load	better [-3.460ms; -2.671ms] or [-7.681%; -5.929%]	unstable [-0.185op/s; +15.260op/s] or [-0.178%; +14.693%]	41.984ms	111.400op/s	45.050ms	103.862op/s
scenario:load:petclinic:appsec:high_load	better [-2.626ms; -1.720ms] or [-5.421%; -3.550%]	unstable [-2.757op/s; +11.757op/s] or [-2.854%; +12.169%]	46.277ms	101.112op/s	48.450ms	96.612op/s
scenario:load:petclinic:iast:high_load	worse [+1.684ms; +2.477ms] or [+3.959%; +5.825%]	unstable [-12.824op/s; +2.649op/s] or [-11.662%; +2.409%]	44.613ms	104.875op/s	42.533ms	109.963op/s
scenario:load:petclinic:code_origins:high_load	worse [+1.143ms; +1.973ms] or [+2.621%; +4.523%]	unstable [-11.089op/s; +3.864op/s] or [-10.342%; +3.604%]	45.175ms	103.612op/s	43.617ms	107.225op/s

Request duration reports for petclinic

gantt
    title petclinic - request duration [CI 0.99] : candidate=1.53.0-SNAPSHOT~658120f76e, baseline=1.53.0-SNAPSHOT~91f463686c
    dateFormat X
    axisFormat %s
section baseline
no_agent (36.459 ms) : 36163, 36754
.   : milestone, 36459,
appsec (48.45 ms) : 48020, 48880
.   : milestone, 48450,
code_origins (43.617 ms) : 43235, 43999
.   : milestone, 43617,
iast (42.533 ms) : 42175, 42890
.   : milestone, 42533,
profiling (48.162 ms) : 47710, 48614
.   : milestone, 48162,
tracing (45.05 ms) : 44672, 45428
.   : milestone, 45050,
section candidate
no_agent (35.614 ms) : 35326, 35902
.   : milestone, 35614,
appsec (46.277 ms) : 45864, 46689
.   : milestone, 46277,
code_origins (45.175 ms) : 44786, 45564
.   : milestone, 45175,
iast (44.613 ms) : 44234, 44993
.   : milestone, 44613,
profiling (48.318 ms) : 47871, 48764
.   : milestone, 48318,
tracing (41.984 ms) : 41630, 42339
.   : milestone, 41984,

baseline results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	36.459 ms [36.163 ms, 36.754 ms]	-
appsec	48.45 ms [48.02 ms, 48.88 ms]	11.991 ms (32.9%)
code_origins	43.617 ms [43.235 ms, 43.999 ms]	7.158 ms (19.6%)
iast	42.533 ms [42.175 ms, 42.89 ms]	6.074 ms (16.7%)
profiling	48.162 ms [47.71 ms, 48.614 ms]	11.704 ms (32.1%)
tracing	45.05 ms [44.672 ms, 45.428 ms]	8.592 ms (23.6%)

candidate results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	35.614 ms [35.326 ms, 35.902 ms]	-
appsec	46.277 ms [45.864 ms, 46.689 ms]	10.663 ms (29.9%)
code_origins	45.175 ms [44.786 ms, 45.564 ms]	9.561 ms (26.8%)
iast	44.613 ms [44.234 ms, 44.993 ms]	8.999 ms (25.3%)
profiling	48.318 ms [47.871 ms, 48.764 ms]	12.704 ms (35.7%)
tracing	41.984 ms [41.63 ms, 42.339 ms]	6.37 ms (17.9%)

Request duration reports for insecure-bank

gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.53.0-SNAPSHOT~658120f76e, baseline=1.53.0-SNAPSHOT~91f463686c
    dateFormat X
    axisFormat %s
section baseline
no_agent (4.306 ms) : 4258, 4353
.   : milestone, 4306,
iast (9.262 ms) : 9103, 9422
.   : milestone, 9262,
iast_FULL (14.174 ms) : 13887, 14461
.   : milestone, 14174,
iast_GLOBAL (10.134 ms) : 9954, 10313
.   : milestone, 10134,
profiling (8.659 ms) : 8521, 8797
.   : milestone, 8659,
tracing (7.636 ms) : 7529, 7744
.   : milestone, 7636,
section candidate
no_agent (4.43 ms) : 4380, 4479
.   : milestone, 4430,
iast (9.393 ms) : 9241, 9545
.   : milestone, 9393,
iast_FULL (14.351 ms) : 14057, 14645
.   : milestone, 14351,
iast_GLOBAL (10.59 ms) : 10403, 10777
.   : milestone, 10590,
profiling (8.881 ms) : 8744, 9017
.   : milestone, 8881,
tracing (7.753 ms) : 7643, 7863
.   : milestone, 7753,

baseline results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	4.306 ms [4.258 ms, 4.353 ms]	-
iast	9.262 ms [9.103 ms, 9.422 ms]	4.957 ms (115.1%)
iast_FULL	14.174 ms [13.887 ms, 14.461 ms]	9.868 ms (229.2%)
iast_GLOBAL	10.134 ms [9.954 ms, 10.313 ms]	5.828 ms (135.4%)
profiling	8.659 ms [8.521 ms, 8.797 ms]	4.354 ms (101.1%)
tracing	7.636 ms [7.529 ms, 7.744 ms]	3.33 ms (77.3%)

candidate results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	4.43 ms [4.38 ms, 4.479 ms]	-
iast	9.393 ms [9.241 ms, 9.545 ms]	4.963 ms (112.0%)
iast_FULL	14.351 ms [14.057 ms, 14.645 ms]	9.921 ms (224.0%)
iast_GLOBAL	10.59 ms [10.403 ms, 10.777 ms]	6.16 ms (139.1%)
profiling	8.881 ms [8.744 ms, 9.017 ms]	4.451 ms (100.5%)
tracing	7.753 ms [7.643 ms, 7.863 ms]	3.323 ms (75.0%)

Dacapo

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
git_branch	master	ygree/error-logs-remediation
git_commit_date	1756932532	1756938857
git_commit_sha	`91f4636`	`658120f`
release_version	1.53.0-SNAPSHOT~91f463686c	1.53.0-SNAPSHOT~658120f76e

See matching parameters

	Baseline	Candidate
application	biojava	biojava
ci_job_date	1756940724	1756940724
ci_job_id	1112552119	1112552119
ci_pipeline_id	75489894	75489894
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version	Linux runner-zfyrx7zua-project-304-concurrent-0-nze5i02x 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux	Linux runner-zfyrx7zua-project-304-concurrent-0-nze5i02x 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 10 metrics, 2 unstable metrics.

Execution time for tomcat

gantt
    title tomcat - execution time [CI 0.99] : candidate=1.53.0-SNAPSHOT~658120f76e, baseline=1.53.0-SNAPSHOT~91f463686c
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.467 ms) : 1456, 1479
.   : milestone, 1467,
appsec (3.591 ms) : 3378, 3804
.   : milestone, 3591,
iast (2.196 ms) : 2133, 2259
.   : milestone, 2196,
iast_GLOBAL (2.241 ms) : 2178, 2305
.   : milestone, 2241,
profiling (2.448 ms) : 2291, 2605
.   : milestone, 2448,
tracing (2.014 ms) : 1965, 2064
.   : milestone, 2014,
section candidate
no_agent (1.471 ms) : 1459, 1482
.   : milestone, 1471,
appsec (3.654 ms) : 3432, 3877
.   : milestone, 3654,
iast (2.203 ms) : 2140, 2266
.   : milestone, 2203,
iast_GLOBAL (2.236 ms) : 2173, 2299
.   : milestone, 2236,
profiling (2.047 ms) : 1996, 2099
.   : milestone, 2047,
tracing (2.025 ms) : 1975, 2074
.   : milestone, 2025,

baseline results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	1.467 ms [1.456 ms, 1.479 ms]	-
appsec	3.591 ms [3.378 ms, 3.804 ms]	2.124 ms (144.7%)
iast	2.196 ms [2.133 ms, 2.259 ms]	728.806 µs (49.7%)
iast_GLOBAL	2.241 ms [2.178 ms, 2.305 ms]	773.928 µs (52.8%)
profiling	2.448 ms [2.291 ms, 2.605 ms]	980.833 µs (66.9%)
tracing	2.014 ms [1.965 ms, 2.064 ms]	547.313 µs (37.3%)

candidate results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	1.471 ms [1.459 ms, 1.482 ms]	-
appsec	3.654 ms [3.432 ms, 3.877 ms]	2.184 ms (148.5%)
iast	2.203 ms [2.14 ms, 2.266 ms]	732.005 µs (49.8%)
iast_GLOBAL	2.236 ms [2.173 ms, 2.299 ms]	765.802 µs (52.1%)
profiling	2.047 ms [1.996 ms, 2.099 ms]	576.694 µs (39.2%)
tracing	2.025 ms [1.975 ms, 2.074 ms]	554.019 µs (37.7%)

Execution time for biojava

gantt
    title biojava - execution time [CI 0.99] : candidate=1.53.0-SNAPSHOT~658120f76e, baseline=1.53.0-SNAPSHOT~91f463686c
    dateFormat X
    axisFormat %s
section baseline
no_agent (14.902 s) : 14902000, 14902000
.   : milestone, 14902000,
appsec (15.059 s) : 15059000, 15059000
.   : milestone, 15059000,
iast (18.727 s) : 18727000, 18727000
.   : milestone, 18727000,
iast_GLOBAL (17.791 s) : 17791000, 17791000
.   : milestone, 17791000,
profiling (15.495 s) : 15495000, 15495000
.   : milestone, 15495000,
tracing (14.817 s) : 14817000, 14817000
.   : milestone, 14817000,
section candidate
no_agent (15.679 s) : 15679000, 15679000
.   : milestone, 15679000,
appsec (14.948 s) : 14948000, 14948000
.   : milestone, 14948000,
iast (18.384 s) : 18384000, 18384000
.   : milestone, 18384000,
iast_GLOBAL (18.178 s) : 18178000, 18178000
.   : milestone, 18178000,
profiling (15.338 s) : 15338000, 15338000
.   : milestone, 15338000,
tracing (14.986 s) : 14986000, 14986000
.   : milestone, 14986000,

baseline results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	14.902 s [14.902 s, 14.902 s]	-
appsec	15.059 s [15.059 s, 15.059 s]	157.0 ms (1.1%)
iast	18.727 s [18.727 s, 18.727 s]	3.825 s (25.7%)
iast_GLOBAL	17.791 s [17.791 s, 17.791 s]	2.889 s (19.4%)
profiling	15.495 s [15.495 s, 15.495 s]	593.0 ms (4.0%)
tracing	14.817 s [14.817 s, 14.817 s]	-85.0 ms (-0.6%)

candidate results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	15.679 s [15.679 s, 15.679 s]	-
appsec	14.948 s [14.948 s, 14.948 s]	-731.0 ms (-4.7%)
iast	18.384 s [18.384 s, 18.384 s]	2.705 s (17.3%)
iast_GLOBAL	18.178 s [18.178 s, 18.178 s]	2.499 s (15.9%)
profiling	15.338 s [15.338 s, 15.338 s]	-341.0 ms (-2.2%)
tracing	14.986 s [14.986 s, 14.986 s]	-693.0 ms (-4.4%)

ygree · 2025-09-03T23:20:57Z

dd-java-agent/agent-tooling/src/main/java/datadog/trace/agent/tooling/HelperInjector.java

                "Failed to inject helper classes - instrumentation.class="
                    + requestingName
                    + " instrumentation.target.classloader={} instrumentation.target.class={}",
-                requestingName,


The requestingName was embedded in the message for telemetry purposes, but the argument wasn't removed.

Thanks. This is exactly the example I had in mind as an approved exception for dynamic messages.

| Package | Type | Package file | Manager | Update | Change | |---|---|---|---|---|---| | [com.datadoghq:dd-trace-api](https://github.com/datadog/dd-trace-java) | dependencies | misk/gradle/libs.versions.toml | gradle | minor | `1.52.1` -> `1.53.0` | --- ### Release Notes <details> <summary>datadog/dd-trace-java (com.datadoghq:dd-trace-api)</summary> ### [`v1.53.0`](https://github.com/DataDog/dd-trace-java/releases/tag/v1.53.0): 1.53.0 ### Components #### Application Security Management (WAF) - 🐛 Fix NullPointerException log in AppSec ([#9355](DataDog/dd-trace-java#9355) - [@jandro996](https://github.com/jandro996)) - ✨ Add Forwarded header as a source to client IP resolution ([#9310](DataDog/dd-trace-java#9310) - [@jandro996](https://github.com/jandro996)) #### Build & Tooling - 📖 Update CODEOWNERS ([#9294](DataDog/dd-trace-java#9294) - [@mhlidd](https://github.com/mhlidd)) - ✨ Add dependency on Maven Central deployment to OCI publish jobs ([#9204](DataDog/dd-trace-java#9204) - [@sarahchen6](https://github.com/sarahchen6)) #### Continuous Integration Visibility - ✨ Upload code coverage reports to Datadog ([#9425](DataDog/dd-trace-java#9425) - [@nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog)) - ✨⚡ Do not follow symlinks by default when building repository index ([#9318](DataDog/dd-trace-java#9318) - [@nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog)) - ✨ Improve tag propagation between test event levels ([#9278](DataDog/dd-trace-java#9278) - [@daniel-mohedano](https://github.com/daniel-mohedano)) #### Data Streams Monitoring - ✨ Create container hash tags propagation ([#9282](DataDog/dd-trace-java#9282) - [@ygree](https://github.com/ygree)) #### Database Monitoring - 🐛 Prevent crash in SQL Server's JDBC when tracing execute methods with generated keys ([#9321](DataDog/dd-trace-java#9321) - [@na-ji](https://github.com/na-ji)) - ✨ Create container hash tags propagation ([#9282](DataDog/dd-trace-java#9282) - [@ygree](https://github.com/ygree)) #### GraalVM native-image - 🐛 Update GraalVM config to reflect TempLocationManager's new package ([#9337](DataDog/dd-trace-java#9337) - [@luneo7](https://github.com/luneo7) - thanks for the contribution!) #### Metrics - 🐛 Add reflect config for CSS and graalvm ([#9449](DataDog/dd-trace-java#9449) - [@amarziali](https://github.com/amarziali)) - ✨ Align CSS health metrics ([#9444](DataDog/dd-trace-java#9444) - [@amarziali](https://github.com/amarziali)) - ✨ Aggregate peer tags for consumer span kind ([#9442](DataDog/dd-trace-java#9442) - [@amarziali](https://github.com/amarziali)) - ✨ Implement health metrics for client stats ([#9377](DataDog/dd-trace-java#9377) - [@amarziali](https://github.com/amarziali)) - ✨ Add peer tags, span kind and trace root flag to MetricKey bucket ([#9178](DataDog/dd-trace-java#9178) - [@bric3](https://github.com/bric3)) #### Profiling - ✨ Create a profile flare reporter (requires tracing or CI vis to be enabled) ([#9433](DataDog/dd-trace-java#9433) - [@MattAlp](https://github.com/MattAlp)) - 🐛 Properly fall-back on UDS profiling URL ([#9401](DataDog/dd-trace-java#9401) - [@jbachorik](https://github.com/jbachorik)) - 🐛 Properly handle trace agent IPv6 URL in profiling ([#9334](DataDog/dd-trace-java#9334) - [@jbachorik](https://github.com/jbachorik)) #### Realtime User Monitoring - 🐛 Avoid multiple injections on dispatch on jboss ([#9392](DataDog/dd-trace-java#9392) - [@amarziali](https://github.com/amarziali)) - ✨ Support async servlet for RUM injection ([#9333](DataDog/dd-trace-java#9333) - [@amarziali](https://github.com/amarziali)) - 🐛 Improve RUM injection matching and avoid truncating responses ([#9323](DataDog/dd-trace-java#9323) - [@amarziali](https://github.com/amarziali)) - 💡 Add telemetry for the RUM injector ([#9267](DataDog/dd-trace-java#9267) - [@sarahchen6](https://github.com/sarahchen6)) - ✨ Make rum injector stream/writer more resilient to errors ([#9184](DataDog/dd-trace-java#9184) - [@amarziali](https://github.com/amarziali)) #### Telemetry - 🐛 Remediate error logs ([#9459](DataDog/dd-trace-java#9459) - [@ygree](https://github.com/ygree)) - ✨ Report config\_id for Hands Off Config files ([#9299](DataDog/dd-trace-java#9299) - [@mtoffl01](https://github.com/mtoffl01)) - ✨ Adding Config Inversion Telemetry component ([#9244](DataDog/dd-trace-java#9244) - [@mhlidd](https://github.com/mhlidd)) #### Trace context propagation - 🧹 Migrate instrumentations to Context API ([#9384](DataDog/dd-trace-java#9384), [#9378](DataDog/dd-trace-java#9378), [#9358](DataDog/dd-trace-java#9358) - [@PerfectSlayer](https://github.com/PerfectSlayer)) - ✨🔍 Add baggage propagation telemetry ([#9289](DataDog/dd-trace-java#9289) - [@rachelyangdog](https://github.com/rachelyangdog)) - 🧹 Improve Instrumenter API to use Context instead of Span ([#9211](DataDog/dd-trace-java#9211) - [@PerfectSlayer](https://github.com/PerfectSlayer)) #### Tracer core - 💡:test\_tube: Enable process level tags for java 21 applications ([#9458](DataDog/dd-trace-java#9458) - [@amarziali](https://github.com/amarziali)) - ✨ Move base and peer service adder before span is published ([#9408](DataDog/dd-trace-java#9408) - [@amarziali](https://github.com/amarziali)) - ✨ Add ErrorPriorities level for manual instrumentation ([#9387](DataDog/dd-trace-java#9387) - [@cecile75](https://github.com/cecile75)) - ✨ Throw InvalidBooleanValueException in ConfigConverter.booleanValueOf ([#9370](DataDog/dd-trace-java#9370) - [@mtoffl01](https://github.com/mtoffl01)) - 🐛 Avoid NPE on featureDiscovery creation ([#9353](DataDog/dd-trace-java#9353) - [@amarziali](https://github.com/amarziali)) - ✨ Stable Config improvements ([#9259](DataDog/dd-trace-java#9259) - [@mtoffl01](https://github.com/mtoffl01)) ### Instrumentations #### gRPC instrumentation - 🐛 Changing GRPC instrumentation codes from `status.code` to `grpc.status.code` ([#9367](DataDog/dd-trace-java#9367) - [@mhlidd](https://github.com/mhlidd)) #### JDBC instrumentation - 🐛 Prevent crash in SQL Server's JDBC when tracing execute methods with generated keys ([#9321](DataDog/dd-trace-java#9321) - [@na-ji](https://github.com/na-ji)) #### Kotlin instrumentation - 🐛 Take defensive copy of original scope stack when restoring on different thread ([#9403](DataDog/dd-trace-java#9403) - [@mcculls](https://github.com/mcculls)) #### OpenTelemetry instrumentation - 🐛 Fix using SpanAttribute annotation on multiple parameters ([#9412](DataDog/dd-trace-java#9412) - [@cecile75](https://github.com/cecile75)) </details> --- ### Configuration 📅 **Schedule**: Branch creation - "after 6pm every weekday,before 2am every weekday" in timezone Australia/Melbourne, Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Never, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). GitOrigin-RevId: e23ec866cef91afc6b5226d5f0dc7da538d947e8

ygree added the type: bug Bug report and fix label Sep 3, 2025

ygree requested review from a team as code owners September 3, 2025 17:32

ygree requested review from PerfectSlayer and removed request for a team September 3, 2025 17:32

ygree added the comp: telemetry Telemetry label Sep 3, 2025

ygree enabled auto-merge (squash) September 3, 2025 17:53

bouwkast requested a review from jbachorik September 3, 2025 18:02

ygree force-pushed the ygree/error-logs-remediation branch from e7c2f3e to 1c949d2 Compare September 3, 2025 22:18

ygree requested a review from a team as a code owner September 3, 2025 22:18

Error Logs Remediation

658120f

ygree force-pushed the ygree/error-logs-remediation branch from 1c949d2 to 658120f Compare September 3, 2025 22:34

ygree added this to the 1.53.0 milestone Sep 3, 2025

ygree commented Sep 3, 2025

View reviewed changes

PerfectSlayer approved these changes Sep 4, 2025

View reviewed changes

ygree merged commit 526075f into master Sep 4, 2025
502 of 503 checks passed

ygree deleted the ygree/error-logs-remediation branch September 4, 2025 05:02

ygree mentioned this pull request Sep 4, 2025

Error Logs Remediation 2 #9467

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Error Logs Remediation#9459

Error Logs Remediation#9459
ygree merged 1 commit intomasterfrom
ygree/error-logs-remediation

ygree commented Sep 3, 2025 •

edited

Loading

Uh oh!

github-actions bot commented Sep 3, 2025 •

edited

Loading

Uh oh!

datadog-datadog-prod-us1 bot commented Sep 3, 2025 •

edited

Loading

Uh oh!

pr-commenter bot commented Sep 3, 2025 •

edited

Loading

Uh oh!

ygree Sep 3, 2025

Uh oh!

smola Sep 8, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

ygree commented Sep 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What Does This Do

Motivation

Additional Notes

Contributor Checklist

Uh oh!

github-actions bot commented Sep 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

datadog-datadog-prod-us1 bot commented Sep 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pr-commenter bot commented Sep 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Benchmarks

Startup

Parameters

Summary

Load

Parameters

Summary

Dacapo

Parameters

Summary

Uh oh!

ygree Sep 3, 2025

Choose a reason for hiding this comment

Uh oh!

smola Sep 8, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

ygree commented Sep 3, 2025 •

edited

Loading

github-actions bot commented Sep 3, 2025 •

edited

Loading

datadog-datadog-prod-us1 bot commented Sep 3, 2025 •

edited

Loading

pr-commenter bot commented Sep 3, 2025 •

edited

Loading