Fix Kafka consumer instrumentation by piochelepiotr · Pull Request #10100 · DataDog/dd-trace-java

piochelepiotr · 2025-12-08T17:17:31Z

What Does This Do

https://github.com/DataDog/dd-trace-java/pull/9974/files introduced an issue:

[dd.trace 2025-12-05 14:09:42:608 +0000] [zio-default-blocking-10] DEBUG datadog.trace.agent.tooling.InstrumenterState - Instrumentation blocked - instrumentation.names=[kafka,kafka-3.8] instrumentation.class=datadog.trace.instrumentation.kafka_clients38.LegacyKafkaConsumerInfoInstrumentation instrumentation.target.classloader=jdk.internal.loader.ClassLoaders$AppClassLoader@4b960b5b
[dd.trace 2025-12-05 14:09:42:609 +0000] [zio-default-blocking-10] DEBUG datadog.trace.agent.tooling.muzzle.MuzzleCheck - Muzzled - instrumentation.names=[kafka,kafka-3.8] instrumentation.class=datadog.trace.instrumentation.kafka_clients38.LegacyKafkaConsumerInfoInstrumentation instrumentation.target.classloader=jdk.internal.loader.ClassLoaders$AppClassLoader@4b960b5b
[dd.trace 2025-12-05 14:09:42:609 +0000] [zio-default-blocking-10] DEBUG datadog.trace.agent.tooling.muzzle.MuzzleCheck - Muzzled mismatch - instrumentation.names=[kafka,kafka-3.8] instrumentation.class=datadog.trace.instrumentation.kafka_clients38.LegacyKafkaConsumerInfoInstrumentation instrumentation.target.classloader=jdk.internal.loader.ClassLoaders$AppClassLoader@4b960b5b muzzle.mismatch="datadog.trace.instrumentation.kafka_clients38.RecordsAdvice:32 Missing class datadog.trace.instrumentation.kafka_clients38.KafkaConsumerInstrumentationHelper"

This is due to a missing helper class in KafkaConsumerInstrumentation.java

Motivation

Additional Notes

Contributor Checklist

Format the title according the contribution guidelines
Assign the type: and (comp: or inst:) labels in addition to any useful labels
Don't use close, fix or any linking keywords when referencing an issue.
Use solves instead, and assign the PR milestone to the issue
Update the CODEOWNERS file on source file addition, move, or deletion
Update the public documentation in case of new configuration flag or behavior

Jira ticket: [PROJ-IDENT]

github-actions · 2025-12-08T17:17:41Z

Hi! 👋 Thanks for your pull request! 🎉

To help us review it, please make sure to:

Add at least one type, and one component or instrumentation label to the pull request

If you need help, please check our contributing guidelines.

pr-commenter · 2025-12-08T17:51:30Z

Kafka / producer-benchmark

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
git_branch	master	piotr.wolski/fix-kafka-instrumentation
git_commit_date	1765198263	1765213909
git_commit_sha	`5c5592a`	`8c64d26`

See matching parameters

	Baseline	Candidate
ci_job_date	1765215195	1765215195
ci_job_id	1276618139	1276618139
ci_pipeline_id	85344713	85344713
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
jdkVersion	11.0.25	11.0.25
jmhVersion	1.36	1.36
jvm	/usr/lib/jvm/java-11-openjdk-amd64/bin/java	/usr/lib/jvm/java-11-openjdk-amd64/bin/java
jvmArgs	-Dfile.encoding=UTF-8 -Djava.io.tmpdir=/go/src/github.com/DataDog/apm-reliability/dd-trace-java/platform/src/producer-benchmark/build/tmp/jmh -Duser.country=US -Duser.language=en -Duser.variant	-Dfile.encoding=UTF-8 -Djava.io.tmpdir=/go/src/github.com/DataDog/apm-reliability/dd-trace-java/platform/src/producer-benchmark/build/tmp/jmh -Duser.country=US -Duser.language=en -Duser.variant
vmName	OpenJDK 64-Bit Server VM	OpenJDK 64-Bit Server VM
vmVersion	11.0.25+9-post-Ubuntu-1ubuntu122.04	11.0.25+9-post-Ubuntu-1ubuntu122.04

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 3 metrics, 0 unstable metrics.

See unchanged results

scenario	Δ mean throughput
scenario:not-instrumented/KafkaProduceBenchmark.benchProduce	same
scenario:only-tracing-dsm-disabled-benchmarks/KafkaProduceBenchmark.benchProduce	same
scenario:only-tracing-dsm-enabled-benchmarks/KafkaProduceBenchmark.benchProduce	same

robcarlan-datadog

LGTM for DSM

pr-commenter · 2025-12-08T18:04:20Z

Benchmarks

Startup

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
git_branch	master	piotr.wolski/fix-kafka-instrumentation
git_commit_date	1765198263	1765213909
git_commit_sha	`5c5592a`	`8c64d26`
release_version	1.57.0-SNAPSHOT~5c5592a6f6	1.57.0-SNAPSHOT~8c64d26100

See matching parameters

	Baseline	Candidate
application	insecure-bank	insecure-bank
ci_job_date	1765216020	1765216020
ci_job_id	1276618134	1276618134
ci_pipeline_id	85344713	85344713
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version	Linux runner-zfyrx7zua-project-304-concurrent-2-xustzi4o 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux	Linux runner-zfyrx7zua-project-304-concurrent-2-xustzi4o 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
module	Agent	Agent
parent	None	None

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 59 metrics, 6 unstable metrics.

Startup time reports for insecure-bank

gantt
    title insecure-bank - global startup overhead: candidate=1.57.0-SNAPSHOT~8c64d26100, baseline=1.57.0-SNAPSHOT~5c5592a6f6

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.079 s) : 0, 1078896
Total [baseline] (8.744 s) : 0, 8743947
Agent [candidate] (1.081 s) : 0, 1081003
Total [candidate] (8.736 s) : 0, 8736460
section iast
Agent [baseline] (1.221 s) : 0, 1220576
Total [baseline] (9.439 s) : 0, 9439115
Agent [candidate] (1.227 s) : 0, 1226687
Total [candidate] (9.456 s) : 0, 9456363

baseline results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.079 s	-
Agent	iast	1.221 s	141.68 ms (13.1%)
Total	tracing	8.744 s	-
Total	iast	9.439 s	695.168 ms (8.0%)

candidate results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.081 s	-
Agent	iast	1.227 s	145.684 ms (13.5%)
Total	tracing	8.736 s	-
Total	iast	9.456 s	719.903 ms (8.2%)

gantt
    title insecure-bank - break down per module: candidate=1.57.0-SNAPSHOT~8c64d26100, baseline=1.57.0-SNAPSHOT~5c5592a6f6

    dateFormat X
    axisFormat %s
section tracing
crashtracking [baseline] (1.194 ms) : 0, 1194
crashtracking [candidate] (1.214 ms) : 0, 1214
BytebuddyAgent [baseline] (647.899 ms) : 0, 647899
BytebuddyAgent [candidate] (649.272 ms) : 0, 649272
GlobalTracer [baseline] (281.137 ms) : 0, 281137
GlobalTracer [candidate] (281.887 ms) : 0, 281887
AppSec [baseline] (32.323 ms) : 0, 32323
AppSec [candidate] (32.31 ms) : 0, 32310
Debugger [baseline] (67.425 ms) : 0, 67425
Debugger [candidate] (67.247 ms) : 0, 67247
Remote Config [baseline] (669.224 µs) : 0, 669
Remote Config [candidate] (654.67 µs) : 0, 655
Telemetry [baseline] (9.01 ms) : 0, 9010
Telemetry [candidate] (8.994 ms) : 0, 8994
Flare Poller [baseline] (3.772 ms) : 0, 3772
Flare Poller [candidate] (3.748 ms) : 0, 3748
section iast
crashtracking [baseline] (1.203 ms) : 0, 1203
crashtracking [candidate] (1.198 ms) : 0, 1198
BytebuddyAgent [baseline] (790.199 ms) : 0, 790199
BytebuddyAgent [candidate] (793.812 ms) : 0, 793812
GlobalTracer [baseline] (254.563 ms) : 0, 254563
GlobalTracer [candidate] (255.392 ms) : 0, 255392
AppSec [baseline] (35.45 ms) : 0, 35450
AppSec [candidate] (35.836 ms) : 0, 35836
Debugger [baseline] (64.539 ms) : 0, 64539
Debugger [candidate] (65.186 ms) : 0, 65186
Remote Config [baseline] (579.993 µs) : 0, 580
Remote Config [candidate] (576.627 µs) : 0, 577
Telemetry [baseline] (8.453 ms) : 0, 8453
Telemetry [candidate] (8.443 ms) : 0, 8443
Flare Poller [baseline] (3.441 ms) : 0, 3441
Flare Poller [candidate] (3.492 ms) : 0, 3492
IAST [baseline] (26.87 ms) : 0, 26870
IAST [candidate] (27.098 ms) : 0, 27098

Startup time reports for petclinic

gantt
    title petclinic - global startup overhead: candidate=1.57.0-SNAPSHOT~8c64d26100, baseline=1.57.0-SNAPSHOT~5c5592a6f6

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.082 s) : 0, 1082486
Total [baseline] (10.864 s) : 0, 10863892
Agent [candidate] (1.088 s) : 0, 1088012
Total [candidate] (10.86 s) : 0, 10859584
section appsec
Agent [baseline] (1.263 s) : 0, 1263283
Total [baseline] (11.098 s) : 0, 11098289
Agent [candidate] (1.262 s) : 0, 1262421
Total [candidate] (11.067 s) : 0, 11067065
section iast
Agent [baseline] (1.227 s) : 0, 1227039
Total [baseline] (11.221 s) : 0, 11220840
Agent [candidate] (1.222 s) : 0, 1222090
Total [candidate] (11.246 s) : 0, 11245993
section profiling
Agent [baseline] (1.208 s) : 0, 1207537
Total [baseline] (10.953 s) : 0, 10952865
Agent [candidate] (1.203 s) : 0, 1203169
Total [candidate] (11.017 s) : 0, 11017391

baseline results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.082 s	-
Agent	appsec	1.263 s	180.796 ms (16.7%)
Agent	iast	1.227 s	144.552 ms (13.4%)
Agent	profiling	1.208 s	125.051 ms (11.6%)
Total	tracing	10.864 s	-
Total	appsec	11.098 s	234.397 ms (2.2%)
Total	iast	11.221 s	356.948 ms (3.3%)
Total	profiling	10.953 s	88.974 ms (0.8%)

candidate results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.088 s	-
Agent	appsec	1.262 s	174.409 ms (16.0%)
Agent	iast	1.222 s	134.078 ms (12.3%)
Agent	profiling	1.203 s	115.157 ms (10.6%)
Total	tracing	10.86 s	-
Total	appsec	11.067 s	207.481 ms (1.9%)
Total	iast	11.246 s	386.408 ms (3.6%)
Total	profiling	11.017 s	157.807 ms (1.5%)

gantt
    title petclinic - break down per module: candidate=1.57.0-SNAPSHOT~8c64d26100, baseline=1.57.0-SNAPSHOT~5c5592a6f6

    dateFormat X
    axisFormat %s
section tracing
crashtracking [baseline] (1.193 ms) : 0, 1193
crashtracking [candidate] (1.204 ms) : 0, 1204
BytebuddyAgent [baseline] (649.734 ms) : 0, 649734
BytebuddyAgent [candidate] (653.028 ms) : 0, 653028
GlobalTracer [baseline] (282.034 ms) : 0, 282034
GlobalTracer [candidate] (283.621 ms) : 0, 283621
AppSec [baseline] (32.271 ms) : 0, 32271
AppSec [candidate] (32.662 ms) : 0, 32662
Debugger [baseline] (68.119 ms) : 0, 68119
Debugger [candidate] (68.344 ms) : 0, 68344
Remote Config [baseline] (641.755 µs) : 0, 642
Remote Config [candidate] (627.511 µs) : 0, 628
Telemetry [baseline] (9.02 ms) : 0, 9020
Telemetry [candidate] (9.076 ms) : 0, 9076
Flare Poller [baseline] (3.851 ms) : 0, 3851
Flare Poller [candidate] (3.815 ms) : 0, 3815
section appsec
crashtracking [baseline] (1.203 ms) : 0, 1203
crashtracking [candidate] (1.201 ms) : 0, 1201
BytebuddyAgent [baseline] (687.727 ms) : 0, 687727
BytebuddyAgent [candidate] (687.972 ms) : 0, 687972
GlobalTracer [baseline] (258.855 ms) : 0, 258855
GlobalTracer [candidate] (258.917 ms) : 0, 258917
AppSec [baseline] (175.05 ms) : 0, 175050
AppSec [candidate] (174.391 ms) : 0, 174391
Debugger [baseline] (66.474 ms) : 0, 66474
Debugger [candidate] (66.439 ms) : 0, 66439
Remote Config [baseline] (717.496 µs) : 0, 717
Remote Config [candidate] (711.071 µs) : 0, 711
Telemetry [baseline] (9.122 ms) : 0, 9122
Telemetry [candidate] (9.122 ms) : 0, 9122
Flare Poller [baseline] (3.956 ms) : 0, 3956
Flare Poller [candidate] (3.953 ms) : 0, 3953
IAST [baseline] (24.693 ms) : 0, 24693
IAST [candidate] (24.404 ms) : 0, 24404
section iast
crashtracking [baseline] (1.2 ms) : 0, 1200
crashtracking [candidate] (1.193 ms) : 0, 1193
BytebuddyAgent [baseline] (792.962 ms) : 0, 792962
BytebuddyAgent [candidate] (790.313 ms) : 0, 790313
GlobalTracer [baseline] (255.786 ms) : 0, 255786
GlobalTracer [candidate] (255.312 ms) : 0, 255312
AppSec [baseline] (34.903 ms) : 0, 34903
AppSec [candidate] (35.137 ms) : 0, 35137
Debugger [baseline] (67.131 ms) : 0, 67131
Debugger [candidate] (65.497 ms) : 0, 65497
Remote Config [baseline] (604.995 µs) : 0, 605
Remote Config [candidate] (559.168 µs) : 0, 559
Telemetry [baseline] (8.586 ms) : 0, 8586
Telemetry [candidate] (8.461 ms) : 0, 8461
Flare Poller [baseline] (3.521 ms) : 0, 3521
Flare Poller [candidate] (3.444 ms) : 0, 3444
IAST [baseline] (26.925 ms) : 0, 26925
IAST [candidate] (26.847 ms) : 0, 26847
section profiling
crashtracking [baseline] (1.206 ms) : 0, 1206
crashtracking [candidate] (1.185 ms) : 0, 1185
BytebuddyAgent [baseline] (703.33 ms) : 0, 703330
BytebuddyAgent [candidate] (701.612 ms) : 0, 701612
GlobalTracer [baseline] (221.413 ms) : 0, 221413
GlobalTracer [candidate] (220.441 ms) : 0, 220441
AppSec [baseline] (32.371 ms) : 0, 32371
AppSec [candidate] (32.112 ms) : 0, 32112
Debugger [baseline] (68.396 ms) : 0, 68396
Debugger [candidate] (67.804 ms) : 0, 67804
Remote Config [baseline] (667.524 µs) : 0, 668
Remote Config [candidate] (605.474 µs) : 0, 605
Telemetry [baseline] (9.041 ms) : 0, 9041
Telemetry [candidate] (8.998 ms) : 0, 8998
Flare Poller [baseline] (3.725 ms) : 0, 3725
Flare Poller [candidate] (3.782 ms) : 0, 3782
ProfilingAgent [baseline] (97.703 ms) : 0, 97703
ProfilingAgent [candidate] (97.152 ms) : 0, 97152
Profiling [baseline] (98.288 ms) : 0, 98288
Profiling [candidate] (97.735 ms) : 0, 97735

Load

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
git_branch	master	piotr.wolski/fix-kafka-instrumentation
git_commit_date	1765198263	1765213909
git_commit_sha	`5c5592a`	`8c64d26`
release_version	1.57.0-SNAPSHOT~5c5592a6f6	1.57.0-SNAPSHOT~8c64d26100

See matching parameters

	Baseline	Candidate
application	insecure-bank	insecure-bank
ci_job_date	1765216501	1765216501
ci_job_id	1276618135	1276618135
ci_pipeline_id	85344713	85344713
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version	Linux runner-zfyrx7zua-project-304-concurrent-1-94nnk5yg 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux	Linux runner-zfyrx7zua-project-304-concurrent-1-94nnk5yg 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux

Summary

Found 0 performance improvements and 3 performance regressions! Performance is the same for 18 metrics, 15 unstable metrics.

scenario	Δ mean agg_http_req_duration_p50	Δ mean agg_http_req_duration_p95	Δ mean throughput	candidate mean agg_http_req_duration_p50	candidate mean agg_http_req_duration_p95	candidate mean throughput	baseline mean agg_http_req_duration_p50	baseline mean agg_http_req_duration_p95	baseline mean throughput
scenario:load:petclinic:tracing:high_load	worse [+0.613ms; +1.608ms] or [+3.503%; +9.198%]	unsure [+0.336ms; +1.959ms] or [+1.174%; +6.843%]	unstable [-37.791op/s; +14.791op/s] or [-14.512%; +5.680%]	18.598ms	29.771ms	248.906op/s	17.488ms	28.623ms	260.406op/s
scenario:load:petclinic:no_agent:high_load	worse [+0.514ms; +1.994ms] or [+2.927%; +11.349%]	worse [+1.019ms; +3.806ms] or [+3.505%; +13.099%]	unstable [-43.426op/s; +11.614op/s] or [-16.777%; +4.487%]	18.826ms	31.467ms	242.938op/s	17.572ms	29.055ms	258.844op/s

Request duration reports for insecure-bank

gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.57.0-SNAPSHOT~8c64d26100, baseline=1.57.0-SNAPSHOT~5c5592a6f6
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.188 ms) : 1177, 1199
.   : milestone, 1188,
iast (3.249 ms) : 3206, 3291
.   : milestone, 3249,
iast_FULL (5.879 ms) : 5819, 5939
.   : milestone, 5879,
iast_GLOBAL (3.656 ms) : 3599, 3713
.   : milestone, 3656,
profiling (2.091 ms) : 2073, 2110
.   : milestone, 2091,
tracing (1.846 ms) : 1831, 1861
.   : milestone, 1846,
section candidate
no_agent (1.186 ms) : 1176, 1197
.   : milestone, 1186,
iast (3.201 ms) : 3157, 3244
.   : milestone, 3201,
iast_FULL (5.892 ms) : 5834, 5951
.   : milestone, 5892,
iast_GLOBAL (3.667 ms) : 3614, 3721
.   : milestone, 3667,
profiling (1.97 ms) : 1953, 1988
.   : milestone, 1970,
tracing (1.787 ms) : 1773, 1801
.   : milestone, 1787,

baseline results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	1.188 ms [1.177 ms, 1.199 ms]	-
iast	3.249 ms [3.206 ms, 3.291 ms]	2.061 ms (173.5%)
iast_FULL	5.879 ms [5.819 ms, 5.939 ms]	4.691 ms (394.9%)
iast_GLOBAL	3.656 ms [3.599 ms, 3.713 ms]	2.468 ms (207.8%)
profiling	2.091 ms [2.073 ms, 2.11 ms]	903.338 µs (76.0%)
tracing	1.846 ms [1.831 ms, 1.861 ms]	657.991 µs (55.4%)

candidate results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	1.186 ms [1.176 ms, 1.197 ms]	-
iast	3.201 ms [3.157 ms, 3.244 ms]	2.014 ms (169.7%)
iast_FULL	5.892 ms [5.834 ms, 5.951 ms]	4.706 ms (396.6%)
iast_GLOBAL	3.667 ms [3.614 ms, 3.721 ms]	2.481 ms (209.1%)
profiling	1.97 ms [1.953 ms, 1.988 ms]	783.6 µs (66.0%)
tracing	1.787 ms [1.773 ms, 1.801 ms]	600.765 µs (50.6%)

Request duration reports for petclinic

gantt
    title petclinic - request duration [CI 0.99] : candidate=1.57.0-SNAPSHOT~8c64d26100, baseline=1.57.0-SNAPSHOT~5c5592a6f6
    dateFormat X
    axisFormat %s
section baseline
no_agent (18.026 ms) : 17843, 18209
.   : milestone, 18026,
appsec (18.211 ms) : 18029, 18394
.   : milestone, 18211,
code_origins (17.661 ms) : 17485, 17837
.   : milestone, 17661,
iast (17.762 ms) : 17585, 17939
.   : milestone, 17762,
profiling (18.398 ms) : 18214, 18582
.   : milestone, 18398,
tracing (17.917 ms) : 17740, 18094
.   : milestone, 17917,
section candidate
no_agent (19.212 ms) : 19014, 19409
.   : milestone, 19212,
appsec (18.35 ms) : 18163, 18536
.   : milestone, 18350,
code_origins (17.919 ms) : 17739, 18100
.   : milestone, 17919,
iast (17.607 ms) : 17431, 17783
.   : milestone, 17607,
profiling (18.658 ms) : 18470, 18846
.   : milestone, 18658,
tracing (18.754 ms) : 18568, 18939
.   : milestone, 18754,

baseline results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	18.026 ms [17.843 ms, 18.209 ms]	-
appsec	18.211 ms [18.029 ms, 18.394 ms]	185.302 µs (1.0%)
code_origins	17.661 ms [17.485 ms, 17.837 ms]	-365.375 µs (-2.0%)
iast	17.762 ms [17.585 ms, 17.939 ms]	-264.121 µs (-1.5%)
profiling	18.398 ms [18.214 ms, 18.582 ms]	371.853 µs (2.1%)
tracing	17.917 ms [17.74 ms, 18.094 ms]	-109.106 µs (-0.6%)

candidate results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	19.212 ms [19.014 ms, 19.409 ms]	-
appsec	18.35 ms [18.163 ms, 18.536 ms]	-861.82 µs (-4.5%)
code_origins	17.919 ms [17.739 ms, 18.1 ms]	-1.292 ms (-6.7%)
iast	17.607 ms [17.431 ms, 17.783 ms]	-1.604 ms (-8.4%)
profiling	18.658 ms [18.47 ms, 18.846 ms]	-553.804 µs (-2.9%)
tracing	18.754 ms [18.568 ms, 18.939 ms]	-458.016 µs (-2.4%)

Dacapo

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
git_branch	master	piotr.wolski/fix-kafka-instrumentation
git_commit_date	1765198263	1765213909
git_commit_sha	`5c5592a`	`8c64d26`
release_version	1.57.0-SNAPSHOT~5c5592a6f6	1.57.0-SNAPSHOT~8c64d26100

See matching parameters

	Baseline	Candidate
application	biojava	biojava
ci_job_date	1765216232	1765216232
ci_job_id	1276618136	1276618136
ci_pipeline_id	85344713	85344713
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version	Linux runner-zfyrx7zua-project-304-concurrent-2-ennf5i8x 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux	Linux runner-zfyrx7zua-project-304-concurrent-2-ennf5i8x 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 10 metrics, 2 unstable metrics.

Execution time for biojava

gantt
    title biojava - execution time [CI 0.99] : candidate=1.57.0-SNAPSHOT~8c64d26100, baseline=1.57.0-SNAPSHOT~5c5592a6f6
    dateFormat X
    axisFormat %s
section baseline
no_agent (14.84 s) : 14840000, 14840000
.   : milestone, 14840000,
appsec (14.617 s) : 14617000, 14617000
.   : milestone, 14617000,
iast (18.575 s) : 18575000, 18575000
.   : milestone, 18575000,
iast_GLOBAL (17.957 s) : 17957000, 17957000
.   : milestone, 17957000,
profiling (14.936 s) : 14936000, 14936000
.   : milestone, 14936000,
tracing (14.849 s) : 14849000, 14849000
.   : milestone, 14849000,
section candidate
no_agent (14.932 s) : 14932000, 14932000
.   : milestone, 14932000,
appsec (14.617 s) : 14617000, 14617000
.   : milestone, 14617000,
iast (18.283 s) : 18283000, 18283000
.   : milestone, 18283000,
iast_GLOBAL (18.004 s) : 18004000, 18004000
.   : milestone, 18004000,
profiling (14.829 s) : 14829000, 14829000
.   : milestone, 14829000,
tracing (14.86 s) : 14860000, 14860000
.   : milestone, 14860000,

baseline results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	14.84 s [14.84 s, 14.84 s]	-
appsec	14.617 s [14.617 s, 14.617 s]	-223.0 ms (-1.5%)
iast	18.575 s [18.575 s, 18.575 s]	3.735 s (25.2%)
iast_GLOBAL	17.957 s [17.957 s, 17.957 s]	3.117 s (21.0%)
profiling	14.936 s [14.936 s, 14.936 s]	96.0 ms (0.6%)
tracing	14.849 s [14.849 s, 14.849 s]	9.0 ms (0.1%)

candidate results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	14.932 s [14.932 s, 14.932 s]	-
appsec	14.617 s [14.617 s, 14.617 s]	-315.0 ms (-2.1%)
iast	18.283 s [18.283 s, 18.283 s]	3.351 s (22.4%)
iast_GLOBAL	18.004 s [18.004 s, 18.004 s]	3.072 s (20.6%)
profiling	14.829 s [14.829 s, 14.829 s]	-103.0 ms (-0.7%)
tracing	14.86 s [14.86 s, 14.86 s]	-72.0 ms (-0.5%)

Execution time for tomcat

gantt
    title tomcat - execution time [CI 0.99] : candidate=1.57.0-SNAPSHOT~8c64d26100, baseline=1.57.0-SNAPSHOT~5c5592a6f6
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.478 ms) : 1466, 1489
.   : milestone, 1478,
appsec (3.715 ms) : 3495, 3934
.   : milestone, 3715,
iast (2.212 ms) : 2147, 2276
.   : milestone, 2212,
iast_GLOBAL (2.256 ms) : 2191, 2321
.   : milestone, 2256,
profiling (2.474 ms) : 2312, 2637
.   : milestone, 2474,
tracing (2.05 ms) : 1999, 2101
.   : milestone, 2050,
section candidate
no_agent (1.473 ms) : 1461, 1484
.   : milestone, 1473,
appsec (3.729 ms) : 3508, 3950
.   : milestone, 3729,
iast (2.218 ms) : 2153, 2283
.   : milestone, 2218,
iast_GLOBAL (2.259 ms) : 2194, 2325
.   : milestone, 2259,
profiling (2.094 ms) : 2040, 2149
.   : milestone, 2094,
tracing (2.049 ms) : 1997, 2100
.   : milestone, 2049,

baseline results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	1.478 ms [1.466 ms, 1.489 ms]	-
appsec	3.715 ms [3.495 ms, 3.934 ms]	2.237 ms (151.4%)
iast	2.212 ms [2.147 ms, 2.276 ms]	733.982 µs (49.7%)
iast_GLOBAL	2.256 ms [2.191 ms, 2.321 ms]	778.08 µs (52.7%)
profiling	2.474 ms [2.312 ms, 2.637 ms]	996.773 µs (67.5%)
tracing	2.05 ms [1.999 ms, 2.101 ms]	571.909 µs (38.7%)

candidate results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	1.473 ms [1.461 ms, 1.484 ms]	-
appsec	3.729 ms [3.508 ms, 3.95 ms]	2.256 ms (153.2%)
iast	2.218 ms [2.153 ms, 2.283 ms]	745.279 µs (50.6%)
iast_GLOBAL	2.259 ms [2.194 ms, 2.325 ms]	786.486 µs (53.4%)
profiling	2.094 ms [2.04 ms, 2.149 ms]	621.57 µs (42.2%)
tracing	2.049 ms [1.997 ms, 2.1 ms]	575.86 µs (39.1%)

pr-commenter · 2025-12-08T18:04:22Z

Kafka / consumer-benchmark

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
git_branch	master	piotr.wolski/fix-kafka-instrumentation
git_commit_date	1765198263	1765213909
git_commit_sha	`5c5592a`	`8c64d26`

See matching parameters

	Baseline	Candidate
ci_job_date	1765215241	1765215241
ci_job_id	1276618140	1276618140
ci_pipeline_id	85344713	85344713
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
jdkVersion	11.0.25	11.0.25
jmhVersion	1.36	1.36
jvm	/usr/lib/jvm/java-11-openjdk-amd64/bin/java	/usr/lib/jvm/java-11-openjdk-amd64/bin/java
jvmArgs	-Dfile.encoding=UTF-8 -Djava.io.tmpdir=/go/src/github.com/DataDog/apm-reliability/dd-trace-java/platform/src/consumer-benchmark/build/tmp/jmh -Duser.country=US -Duser.language=en -Duser.variant	-Dfile.encoding=UTF-8 -Djava.io.tmpdir=/go/src/github.com/DataDog/apm-reliability/dd-trace-java/platform/src/consumer-benchmark/build/tmp/jmh -Duser.country=US -Duser.language=en -Duser.variant
vmName	OpenJDK 64-Bit Server VM	OpenJDK 64-Bit Server VM
vmVersion	11.0.25+9-post-Ubuntu-1ubuntu122.04	11.0.25+9-post-Ubuntu-1ubuntu122.04

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 3 metrics, 0 unstable metrics.

See unchanged results

scenario	Δ mean throughput
scenario:not-instrumented/KafkaConsumerBenchmark.benchConsume	same
scenario:only-tracing-dsm-disabled-benchmarks/KafkaConsumerBenchmark.benchConsume	same
scenario:only-tracing-dsm-enabled-benchmarks/KafkaConsumerBenchmark.benchConsume	unsure [+69.082op/s; +7434.235op/s] or [+0.042%; +4.508%]

fix Kafka consumer instrumentation

8c64d26

piochelepiotr requested a review from a team as a code owner December 8, 2025 17:17

piochelepiotr temporarily deployed to ci-build December 8, 2025 17:17 — with GitHub Actions Inactive

piochelepiotr added comp: data streams Data Streams Monitoring inst: kafka Kafka instrumentation type: bug Bug report and fix labels Dec 8, 2025

robcarlan-datadog approved these changes Dec 8, 2025

View reviewed changes

dougqh approved these changes Dec 8, 2025

View reviewed changes

piochelepiotr merged commit 94e770c into master Dec 8, 2025
709 of 715 checks passed

piochelepiotr deleted the piotr.wolski/fix-kafka-instrumentation branch December 8, 2025 19:35

github-actions bot added this to the 1.57.0 milestone Dec 8, 2025

piochelepiotr mentioned this pull request Dec 8, 2025

fix Kafka consumer instrumentation #10102

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix Kafka consumer instrumentation#10100

Fix Kafka consumer instrumentation#10100
piochelepiotr merged 1 commit intomasterfrom
piotr.wolski/fix-kafka-instrumentation

piochelepiotr commented Dec 8, 2025

Uh oh!

github-actions bot commented Dec 8, 2025 •

edited

Loading

Uh oh!

pr-commenter bot commented Dec 8, 2025

Uh oh!

robcarlan-datadog left a comment

Uh oh!

pr-commenter bot commented Dec 8, 2025

Uh oh!

pr-commenter bot commented Dec 8, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

piochelepiotr commented Dec 8, 2025

What Does This Do

Motivation

Additional Notes

Contributor Checklist

Uh oh!

github-actions bot commented Dec 8, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pr-commenter bot commented Dec 8, 2025

Kafka / producer-benchmark

Parameters

Summary

Uh oh!

robcarlan-datadog left a comment

Choose a reason for hiding this comment

Uh oh!

pr-commenter bot commented Dec 8, 2025

Benchmarks

Startup

Parameters

Summary

Load

Parameters

Summary

Dacapo

Parameters

Summary

Uh oh!

pr-commenter bot commented Dec 8, 2025

Kafka / consumer-benchmark

Parameters

Summary

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

github-actions bot commented Dec 8, 2025 •

edited

Loading