Replace packLib's custom theorems with ThyDataSexp #714
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change just uses library-local parsing to avoid having to store a big theorem of a term-alist.
They now attempt to embody a "more modern" style, as conveyed to me by Magnus.
Contributor
|
Bootstrap translation took more than 17 hours rather than the expected 3-4 hours. I therefore mark the current state as test failing. |
myreen
approved these changes
Jan 8, 2020
Contributor
Author
|
Can you set up a fresh regression test for this branch please? My local tests indicate it to now be faster than |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This has no huge advantage except that it doesn't contaminate the theorem database with encoded state (which then show up as results to
DB.matchetc). It's nice also to use standard HOL APIs.Some uses of
packLibwere entirely removed in favour of just quoting terms and types inLib.smlfiles directly, which can be done safely with local rebinding of theParsestructure.