Add support for (double) floating-point arithmetic to the translator #657
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xrchz
requested changes
May 29, 2019
Member
xrchz
left a comment
There was a problem hiding this comment.
Looks fine except for a suspicious possible typo.
Member
|
Thanks for fixing the typo. Why were changes to this list of "basic theories" required anyway? I think it's a bad sign that there's a hardcoded list of theory names in the translator. Maybe @myreen could comment on whether the changes to this list make sense or not? |
Contributor
Author
|
The change was not required. I saw the list of basic theories and my assumption was that it needs to be extended. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the appropriate theorems and automation to
ml_translatorScript/ml_translatorLib.smlto support floating-point arithmetic in the translator.There are also 2 simple tests in
ml_translator_testScript.sml.Closes #636