Make translator aware of datatype constructors that live inside modules #512
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lookup_cons can now look up a constructor name defined anywhere (not just Short names). This commit fixes the breakage in the translator so that translation works through the entire basis library, at least. ml_monad_translatorScript.sml is fixed too, but ml_monad_translatorLib.sml remains broken by these changes.
Member
|
Nice work! Breaks the bootstrap translation currently. Reopen when fixed. |
Member
|
Now is the bootstrap translation diverging? |
Contributor
Author
|
Yes, there's likely a never-ending metis_tac in an EqualityType proof. I'll re-open this later. |
Contributor
Author
|
I re-wrote the EqualityType proof in the translator w/o metis-calls in a way so that it hopefully can't get stuck forever on things. It seems a lot of |
To get the regression test running again...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should hopefully fix issue #374.
The translator asks
ml_progLibfor the current module when a type is registered, so take care when callingregister_typeon types that would causeregister_typeto get called recursively, or those things might also end up as if they are living within your module.