-
Notifications
You must be signed in to change notification settings - Fork 92
Type+module update #500
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Type+module update #500
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Needs to be updated for GlobalVar{Alloc,Lookup}
currently stuck on true_tag/false_tag mismatch
- unclear if this is the right approach
- Issue: inf_tid_rename ... doesn't commute with t_walkstar because t_walkstar could produce new Infer_Tapp after constraining unification variables.
just one cheat in the Dletrec case (but all this might have to change if the state relation changes)
Add (dummy) compile field to flat_to_patProof to do so. clos_to_bvlProof now required.
- After discussion with Scott and Ramana
This reverts commit 0d85e48.
This reverts commit 0be123b.
Make one code table entry per expression, in addition to all of the stubs and entries for user code. Remove unused stubs for equality and ToList.
Also add simple corollary stating that ptree_Type is a surjection onto all user-expressible types. New tmu AST also means that user-expressible looks much more reasonable than it used to: now the only thing ptree_Type can't hit is a tuple type with fewer than two arguments.
Needed to delete a reference to an astTheory constant and theorem that no longer exist.
The hope is to be able to use the correctness theorem for compile_exps, rather than needing a new one...
with Magnus
Trying to clean up closLang proofs so that syntactic constraints can be defined as constants and their preservation is easier to prove.
The type is defined outside the module (in std_prelude)
They could be better still (and many other error messages need improvement), but this didn't require changing any proofs.
- also NONE -> None, SOME -> Some
- it doesn't quite work when it hits an error message pmatch though
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.