Skip to content

Divsem #496

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
xrchz merged 53 commits into from
Jul 9, 2018
Merged

Divsem #496

xrchz merged 53 commits into from
Jul 9, 2018

Conversation

@IlmariReissumies
Copy link
Member

@IlmariReissumies IlmariReissumies commented Jul 2, 2018

This pull requests extirpates the final event component from the ffi state, and instead stops evaluation whenever FFI divergence or FFI failure is encountered.

@SOwens: I'm tagging you as reviewer because I hope you might check if the lem changes make sense :)

Johannes Åman Pohjola and others added 30 commits June 18, 2018 11:35
Make top-level semantics disregard type errors after the final event
5c80b43
Update semantics to not evaluate past final event
9c939f7
"Fix" location of Rffi_error in lem file
630a4f3 
Scare quotes because I haven't actually tried to invoke lem on the thing.
Update some props for when evaluate stops when FFI stops
0921a7b
Update type soundness proofs for removal of final event
7d348fb
Update semanticsProps for final events change
3943fcf
Update alt_semantics proofs for evaluator changes
b300e92
Make CF theories build without final_event
d93d1c4
Change basis ffi for final_event removal
9ccd164
@myreen
Update all IL sems for removal of final_event
4fbfab0 
Note this commit does not touch the Props files.
@myreen
Update {stack,lab,target}Props for lack of final_event
f177120
@myreen
Start updating {clos,word}Props
6a8b098
@myreen
Finish wordProps for removal of final_event
e61b2b2
@myreen
Update {con,dec,exh,mod,pat}Props for final_event
cf50da3
@myreen
Update closProps for removal of final event
33a1fd9
@myreen
Update {bvl,bvi,data}Props for removal of final event
162a498
@myreen
Update data_spaceProof for removal of final event
d0e6f86
Update clos_annotateProof for removal of final event
3287baf
Update bvi_to_dataProof for final event removal
8285de7
Update clos_knownProof for removal of final event
522f0cd 
No attempt made to fix the various cheats that were present already
Update bvl_inlineProof for removal of final event
013041b
Update clos_call for removal of final event
bd07b9d
Update source_to_modProof for final event removal
be3a79c
Update clos_numberProof for removal of final event
59dd6fe
Update bvi_tailrecProof for final event removal
7bcb01e
Add missing conjunct to stackLang semantics
5dac74b
Update con_to_decProof for final event removal
8f1d550
Update word_simpProof for final event removal
f651214
Update exh_reorderProof for final event removal
5d66da8
Update exh_to_patProof for final event removal
8859c8c
Johannes Åman Pohjola added 22 commits June 29, 2018 12:15
Update lab_filterProof for final event removal
7192573
Update stack_removeProof for final event removal
d2fddc4
Force second FFI argument to be mutable in closSem
40fe4f9 
The lower-case f meant that immutable byte arrays could be mutated if
passed as the second argument to an FFI call.
Add missing conjunst to bviSem
f5828a6
Update dec_to_exhProof for final event removal
9d3f25c
Update bvi_tailrecProof for semantics fix
7159c53
Update pat_to_closProof for final event removal
620f53d
Update bvi_to_dataProof for semantics fix
2fb8b17 
Also: shorter and less convoluted proof of semantics theorem.
Update clos_to_bvlProof for final event removal
477dcba
Update word_to_stackProof for final event removal
856c739
Update bvl_to_bviProof for final event removal
b1525ae
Update stack_allocProof for final event removal
dc33e58
Add missing conjunct to data semantics
6a43a96
Update stack_namesProof for final event removal
b17b250
Update mod_to_conProof for final event removal
7f3e790
Update word_allocProof for final event removal
52286fb
Update lab_to_targetProof for final event removal
3b9209c
Update stack_to_labProof for final event removal
0fbfe8b
Update data_to_word_assignProof for final event removal
693b792
Fix typos
5f38a07
Update data_to_wordProof for final event removal
3fe219c
Clean out various cruft
36fa403
@IlmariReissumies IlmariReissumies requested a review from SOwens July 2, 2018 18:12
@IlmariReissumies IlmariReissumies removed the request for review from SOwens July 4, 2018 09:31
@xrchz
Copy link
Member

xrchz commented Jul 6, 2018

I would like to see x64BootstrapProof go through with these changes before merging. (Sadly the regression test seems to have died on the first attempt to get there.)

@IlmariReissumies
Copy link
Member Author

IlmariReissumies commented Jul 6, 2018

It's unlikely that this PR has any impact on bootstrap since it doesn't touch the compiler, only semantics and proofs. And x64BootstrapProof is basically identical to the stuff in examples/proofs, which did go through.

With that said, I'm not in a rush; I'm happy to wait for a full bootstrap to go through if that's your preference.

@xrchz
Copy link
Member

xrchz commented Jul 6, 2018

My reasoning is that x64BootstrapProof depends on the compiler proofs, which have been changed.

@xrchz xrchz merged commit 645d4af into master Jul 9, 2018
@xrchz xrchz deleted the divsem branch July 9, 2018 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@IlmariReissumies @xrchz @myreen @tanyongkiam